Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ:1708232 - Adds Java S2I content #32543

Merged
merged 1 commit into from
Jul 13, 2021
Merged

BZ:1708232 - Adds Java S2I content #32543

merged 1 commit into from
Jul 13, 2021

Conversation

hmaclean73
Copy link
Contributor

@hmaclean73 hmaclean73 commented May 14, 2021 •
edited
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1708232

Preview: https://deploy-preview-32543--osdocs.netlify.app/openshift-enterprise/latest/using_images/s2i_images/java.html

For 3.11 - Adds Java S2I content.
For OpenShift Online - Updates Java S2I content.

@jmtd This PR adds the initial Java S2I content from the OpenShift Online docs to the 3.11 docs. Ready for your review.

Ready for QE review: @wzheng1

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2021
@netlify
Copy link

netlify bot commented May 14, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 4d466dc

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60e8b74d8018670007883eee

😎 Browse the preview: https://deploy-preview-32543--osdocs.netlify.app/openshift-enterprise/latest/using_images/s2i_images/java

@mburke5678 mburke5678 added branch/enterprise-3.11 do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 14, 2021
@mburke5678 mburke5678 added this to the Next Release milestone May 14, 2021
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2021
@hmaclean73 hmaclean73 force-pushed the BZ1708232 branch 2 times, most recently from 6d5cf11 to b75acdf Compare June 9, 2021 15:13
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2021
@hmaclean73 hmaclean73 force-pushed the BZ1708232 branch 3 times, most recently from 7c8a632 to e280da2 Compare June 16, 2021 13:36
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2021
@hmaclean73
Copy link
Contributor Author

@jmtd Can you please review the latest updates and let me know if all looks good?

@jmtd
Copy link

jmtd commented Jun 25, 2021

This looks good to me. There's one minor suggested addition I would make, in the "Images" section towards the beginning of the document: registry.redhat.io requires authentication to pull from, which requires some set-up. Perhaps a note like the following (adapted from some boilerplate we had in Errata texts):

Note: registry.redhat.io requires authentication.
Please refer to the following Knowledge Base article for details on
how to configure your environment for registry.redhat.io:
https://access.redhat.com/RegistryAuthentication

That aside, the rest is great!

@hmaclean73 hmaclean73 force-pushed the BZ1708232 branch 2 times, most recently from 84a5aa2 to d0c1d4a Compare June 25, 2021 19:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2021
@wzheng1
Copy link

wzheng1 commented Jun 28, 2021

Openshift QE is not responsible this kind of change, it should be covered by Middleware QE(Sorry, I don't know who it will be, so cannot re-assign).

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 9, 2021
@bmcelvee
Copy link
Contributor

bmcelvee commented Jul 9, 2021

A few edits and suggestions, otherwise LGTM!

@hmaclean73
Copy link
Contributor Author

Thanks for reviewing @bmcelvee! Will make the changes and update the PR.

@hmaclean73 hmaclean73 force-pushed the BZ1708232 branch 2 times, most recently from cb58e58 to 7ff424b Compare July 9, 2021 20:32
@jmtd
Copy link

jmtd commented Jul 12, 2021 •
edited
Loading

Since @bmcelvee has reviewed text that originated in the YAML files from the container image sources, I'll make sure we feed back the improvements to there. Thanks! (Edit: tracking issue jboss-container-images/openjdk#226)

@jmtd jmtd mentioned this pull request Jul 12, 2021
Open
@bmcelvee bmcelvee merged commit d1670c9 into openshift:enterprise-3.11 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcelvee bmcelvee bmcelvee left review comments

@jmtd jmtd jmtd approved these changes

@sefroberg sefroberg sefroberg approved these changes

Assignees
No one assigned
Labels
branch/enterprise-3.11 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
6 participants
@hmaclean73 @jmtd @wzheng1 @bmcelvee @sefroberg @mburke5678