Skip to content

WIP: CORENET-5853: Implement changes in openshift-api-server related to project request logic and addition of API field label for UDN #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

miheer
Copy link
Contributor

@miheer miheer commented Apr 8, 2025

Adds an API field called UDNName for Project Request
Adds logic to use the new API field for selecting UDN during project creation.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@miheer: This pull request references CORENET-5853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Adds an API field called UDNName for Project Request
Adds logic to use the new API field for selecting UDN during project creation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2025
@openshift-ci openshift-ci bot requested review from deads2k and derekwaynecarr April 8, 2025 02:34
@miheer miheer changed the title CORENET-5853: Implement changes in openshift-api-server related to project request logic and addition of API field label for UDN WIP: CORENET-5853: Implement changes in openshift-api-server related to project request logic and addition of API field label for UDN Apr 8, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2025
Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miheer
Once this PR has been reviewed and has the lgtm label, please assign benluddy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…oject request logic and addition of API field label for UDN
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@miheer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-cmd b607d9d link false /test e2e-aws-ovn-cmd
ci/prow/okd-scos-e2e-aws-ovn b607d9d link false /test okd-scos-e2e-aws-ovn
ci/prow/images b607d9d link true /test images
ci/prow/unit b607d9d link true /test unit
ci/prow/okd-scos-images b607d9d link true /test okd-scos-images
ci/prow/e2e-aws-ovn-serial b607d9d link true /test e2e-aws-ovn-serial
ci/prow/verify-deps b607d9d link true /test verify-deps
ci/prow/e2e-aws-ovn-upgrade b607d9d link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn b607d9d link true /test e2e-aws-ovn
ci/prow/verify b607d9d link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants