Skip to content

OCPBUGS-16605: Update gitlab.go to fix webhook build issues. #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sferich888
Copy link

Fixes: OCPBUGS-16605

Gitlab some time back, with https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68168, changed its behavior to list commits order, presented from the webhook implementation, from oldest-to-newest to newest-to-oldest (back as far as the 14.x versions of gitlab).

This change fixes the webhook controllers behavior so that it properly selects the latest build when a new build is triggered.

Fixes: OCPBUGS-16605

Gitlab some time back, with https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68168,  changed its behavior to list commits order, presented from the webhook implementation, from oldest-to-newest to newest-to-oldest  (back as far as the 14.x versions of gitlab). 

This change fixes the webhook controllers behavior so that it properly selects the latest build when a new build is triggered.
@sferich888 sferich888 changed the title Update gitlab.go to fix webhook build issues. OCPBUGS-16605: Update gitlab.go to fix webhook build issues. Apr 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2025
@openshift-ci-robot
Copy link

@sferich888: This pull request references Jira Issue OCPBUGS-16605, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: OCPBUGS-16605

Gitlab some time back, with https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68168, changed its behavior to list commits order, presented from the webhook implementation, from oldest-to-newest to newest-to-oldest (back as far as the 14.x versions of gitlab).

This change fixes the webhook controllers behavior so that it properly selects the latest build when a new build is triggered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from coreydaley and deads2k April 7, 2025 11:29
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sferich888
Once this PR has been reviewed and has the lgtm label, please assign coreydaley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@sferich888: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-cmd d1b46ef link false /test e2e-aws-ovn-cmd
ci/prow/e2e-aws-ovn d1b46ef link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade d1b46ef link true /test e2e-aws-ovn-upgrade
ci/prow/unit d1b46ef link true /test unit
ci/prow/e2e-aws-ovn-builds d1b46ef link true /test e2e-aws-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants