-
Notifications
You must be signed in to change notification settings - Fork 94
OCPBUGS-16605: Update gitlab.go to fix webhook build issues. #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes: OCPBUGS-16605 Gitlab some time back, with https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68168, changed its behavior to list commits order, presented from the webhook implementation, from oldest-to-newest to newest-to-oldest (back as far as the 14.x versions of gitlab). This change fixes the webhook controllers behavior so that it properly selects the latest build when a new build is triggered.
@sferich888: This pull request references Jira Issue OCPBUGS-16605, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sferich888 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sferich888: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes: OCPBUGS-16605
Gitlab some time back, with https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68168, changed its behavior to list commits order, presented from the webhook implementation, from oldest-to-newest to newest-to-oldest (back as far as the 14.x versions of gitlab).
This change fixes the webhook controllers behavior so that it properly selects the latest build when a new build is triggered.