Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing /sys/fs/selinux/avc/cache_threshold to 8192 instead of 65535 #10027

Merged
merged 1 commit into from
Sep 12, 2018
Merged

reducing /sys/fs/selinux/avc/cache_threshold to 8192 instead of 65535 #10027

merged 1 commit into from
Sep 12, 2018

Conversation

ekuric
Copy link
Contributor

@ekuric ekuric commented Sep 12, 2018

Creating 500 pods / node and testing various values 512,1024,2048,4096,8192,16384,32768,65535
it was noticed that for case when /sys/fs/selinux/avc/cache_threshold is lower than current 65535 will
result to similar number of entries for RECLAIMS, MISSES in /sys/fs/selinux/avc/cache_stats for case
when 500 pods / OCP node was created

This PR will reduce /sys/fs/selinux/avc/cache_threshold from current 65535 to 8192 based on this test

Signed-off-by: Elvir Kuric [email protected]

Creating 500 pods  / node and testing various values 512,1024,2048,4096,8192,16384,32768,65535
it was noticed that for case when /sys/fs/selinux/avc/cache_threshold is lower than current 65535 will
result to similar number of entries for RECLAIMS, MISSES in /sys/fs/selinux/avc/cache_stats for case
when 500 pods / OCP node was created

This PR will reduce /sys/fs/selinux/avc/cache_threshold from current 65535 to 8192 based on this test

Signed-off-by: Elvir Kuric <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2018
@jeremyeder
Copy link
Contributor

c.f. #9923

@fcami @eparis

@fcami
Copy link

fcami commented Sep 12, 2018

Thanks for looking into this @ekuric @jeremyeder @eparis

@eparis
Copy link
Member

eparis commented Sep 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@eparis
Copy link
Member

eparis commented Sep 12, 2018

/lgtm cancel
Sorry, I forget, all openshift-ansible PRs should be against the release-3.11 branch.. It's a bit weird/funky...
Or @sdodson can say i'm wrong and re-LGTM...

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
Copy link
Contributor

@jmencak jmencak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm based on the results

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2018
@sdodson
Copy link
Member

sdodson commented Sep 12, 2018

Sorry, I forget, all openshift-ansible PRs should be against the release-3.11 branch.. It's a bit weird/funky...
Or @sdodson can say i'm wrong and re-LGTM...

@eparis

Everyone is trained to open against master first. I'm afraid unless we have the bot block merges to master without a special flag we're fighting an uphill battle. If everyone keeps cherrypicking as normal then we're fine. It's a burden but I'd rather have clear and concise policy.

/lgtm
/cherrypick release-3.11

@openshift-cherrypick-robot

@sdodson: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

Sorry, I forget, all openshift-ansible PRs should be against the release-3.11 branch.. It's a bit weird/funky...
Or @sdodson can say i'm wrong and re-LGTM...

@eparis

Everyone is trained to open against master first. I'm afraid unless we have the bot block merges to master without a special flag we're fighting an uphill battle. If everyone keeps cherrypicking as normal then we're fine. It's a burden but I'd rather have clear and concise policy.

/lgtm
/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekuric, jmencak, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Sep 12, 2018

I realize that's contrary to what I'd suggested a mere two days ago though.

@eparis
Copy link
Member

eparis commented Sep 12, 2018

you're the boss!

@openshift-merge-robot openshift-merge-robot merged commit b70d466 into openshift:master Sep 12, 2018
@openshift-cherrypick-robot

@sdodson: new pull request created: #10037

In response to this:

Sorry, I forget, all openshift-ansible PRs should be against the release-3.11 branch.. It's a bit weird/funky...
Or @sdodson can say i'm wrong and re-LGTM...

@eparis

Everyone is trained to open against master first. I'm afraid unless we have the bot block merges to master without a special flag we're fighting an uphill battle. If everyone keeps cherrypicking as normal then we're fine. It's a burden but I'd rather have clear and concise policy.

/lgtm
/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants