-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reducing /sys/fs/selinux/avc/cache_threshold to 8192 instead of 65535 #10027
reducing /sys/fs/selinux/avc/cache_threshold to 8192 instead of 65535 #10027
Conversation
Creating 500 pods / node and testing various values 512,1024,2048,4096,8192,16384,32768,65535 it was noticed that for case when /sys/fs/selinux/avc/cache_threshold is lower than current 65535 will result to similar number of entries for RECLAIMS, MISSES in /sys/fs/selinux/avc/cache_stats for case when 500 pods / OCP node was created This PR will reduce /sys/fs/selinux/avc/cache_threshold from current 65535 to 8192 based on this test Signed-off-by: Elvir Kuric <[email protected]>
@jeremyeder @jmencak PTAL |
Thanks for looking into this @ekuric @jeremyeder @eparis |
/lgtm |
/lgtm cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm based on the results
Everyone is trained to open against master first. I'm afraid unless we have the bot block merges to master without a special flag we're fighting an uphill battle. If everyone keeps cherrypicking as normal then we're fine. It's a burden but I'd rather have clear and concise policy. /lgtm |
@sdodson: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekuric, jmencak, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I realize that's contrary to what I'd suggested a mere two days ago though. |
you're the boss! |
@sdodson: new pull request created: #10037 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Creating 500 pods / node and testing various values 512,1024,2048,4096,8192,16384,32768,65535
it was noticed that for case when /sys/fs/selinux/avc/cache_threshold is lower than current 65535 will
result to similar number of entries for RECLAIMS, MISSES in /sys/fs/selinux/avc/cache_stats for case
when 500 pods / OCP node was created
This PR will reduce /sys/fs/selinux/avc/cache_threshold from current 65535 to 8192 based on this test
Signed-off-by: Elvir Kuric [email protected]