Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-admin CRD compatibility update for 128 #1607

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mpryc
Copy link
Contributor

@mpryc mpryc commented Dec 10, 2024

CRD updates for the following non-admin PR:
migtools/oadp-non-admin#128

Why the changes were made

Required for the Non-Admin PR.

How to test the changes made

Created using the following shell command:

make update-non-admin-manifests

CRD updates for the following non-admin PR:
  migtools/oadp-non-admin#128

Signed-off-by: Michal Pryc <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@mpryc
Copy link
Contributor Author

mpryc commented Dec 11, 2024

/test 4.16-e2e-test-aws

@mpryc
Copy link
Contributor Author

mpryc commented Dec 11, 2024

/retest-required

Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, mpryc, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mateusoliveira43,mpryc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ac85f43 and 2 for PR HEAD 54331c0 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ac85f43 and 2 for PR HEAD 54331c0 in total

Copy link

openshift-ci bot commented Dec 20, 2024

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bddf645 into openshift:master Dec 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants