Removed random time.Sleep in favor of managed k8s wait.For

[btoll]

What is being added?

Fix for a potential bug

Having arbitrary sleeps is much more brittle than waiting on a specific resource.  Let's use a library function from the Kubernetes author like is done in many other of our test suites.

Checklist before requesting review

• [ x] I have tested this locally

Steps To Manually Test

$ cd managed-node-metadata-operator/test/e2e
$ OCM_TOKEN=$(ocm token) OCM_CLUSTER_ID=2iep1m2q79usmnolvj6tpuhfarvoi76g OCM_ENV=stage DISABLE_JUNIT_REPORT=true ginkgo run --tags=osde2e,e2e --procs 4 --flake-attempts 3 --trace -vv .

Ref OSD-29388

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[clcollins]

/lgtm

LGTM, but Rocket isn't listed in the owners/approvers or Slack handle, even though it's assigned to us. Will work on getting that fixed.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.11%. Comparing base (c23803d) to head (30a5178).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   52.11%   52.11%           
=======================================
  Files           4        4           
  Lines         236      236           
=======================================
  Hits          123      123           
  Misses         93       93           
  Partials       20       20           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[btoll]

/retest

[btoll]

/retest

[btoll]

/retest

[btoll]

/retest

[openshift-ci]

@btoll: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/validate	30a5178	link	true	/test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: btoll, christophermancini, clcollins
Once this PR has been reviewed and has the lgtm label, please assign bergmannf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[christophermancini]

Assuming CICD passes, this lgtm