Skip to content

MCO-1661: Feature Gate handling rework #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

MCO-1661: Feature Gate handling rework #5029

wants to merge 2 commits into from

Conversation

pablintino
Copy link
Contributor

- What I did

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pablintino pablintino changed the title MCO-1661 Feature Gate handling rework MCO-1661: Feature Gate handling rework May 5, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 5, 2025 •
edited by openshift-ci bot
Loading

@pablintino: This pull request references MCO-1661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pablintino pablintino force-pushed the featuregate-handler-rework branch 4 times, most recently from 98d0cad to eec056e Compare May 6, 2025 12:50
@pablintino pablintino marked this pull request as ready for review May 6, 2025 13:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
@openshift-ci openshift-ci bot requested review from sohankunkerkar and umohnani8 May 6, 2025 13:50
@pablintino pablintino force-pushed the featuregate-handler-rework branch from eec056e to c896109 Compare May 6, 2025 13:50
@pablintino
Copy link
Contributor Author

/test e2e-hypershift

@pablintino pablintino force-pushed the featuregate-handler-rework branch from c896109 to d118434 Compare May 13, 2025 09:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
pablintino added 2 commits May 13, 2025 12:01
@pablintino
MCO-1661: Add a centralized FeatureGate handler
1f99680 
This commit implements a wrapper around featuregates.FeatureGateAccess
to centralize the way we handle FeatureGates checks.
The handler exposes a few error-free methods to check if a FeatureGate
is enabled or not or if it exist or not.
@pablintino
MCO-1661: Introduce FeatureGatesHandler across MCO
0fcaf58 
This commit replaces plain accesses to FeatureGateAccess with proper
usages of the new FeatureGatesHandler and simplifies most of the error
checks needed in the previous approach.
@pablintino pablintino force-pushed the featuregate-handler-rework branch from d118434 to 0fcaf58 Compare May 13, 2025 10:16
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2025

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl 0fcaf58 link false /test e2e-gcp-op-ocl
ci/prow/unit 0fcaf58 link true /test unit
ci/prow/e2e-azure-ovn-upgrade-out-of-change 0fcaf58 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-single-node 0fcaf58 link true /test e2e-gcp-op-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablintino @openshift-ci-robot @openshift-merge-robot