-
Notifications
You must be signed in to change notification settings - Fork 425
OCPBUGS-55365: Regardless of Pool configuration wait on other sub-controllers to Render #5022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…configuration kubelet_congfig_controller: Don't wait for Pool to be configured to sync
@RishabhSaini: This pull request references Jira Issue OCPBUGS-55365, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RishabhSaini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@RishabhSaini: This pull request references Jira Issue OCPBUGS-55365, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
render_controller: Wait for other sub-controllers regardless of Pool configuration
kubelet_congfig_controller: Don't wait for Pool to be configured to sync
- How to verify it
Install a custom CRC or KC at install time and see if the render_controller waits for the ContainerRuntimeConfig Controller and the KubeletConfigController before it proceeds to generate a rendered MC
- Description for the changelog