Skip to content

[release-4.15] OCPBUGS-53248: Enforce VIPs to be collocated at the same host #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-53248: Enforce VIPs to be collocated at the same host #4988

wants to merge 1 commit into from
+95 −0

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4923

/assign MaysaMacedo

@MaysaMacedo
Enforce VIPs to be collocated at the same host
a3c095e 
When using dual-stack with OpenStack, both IPv4 and IPv6
share the same Neutron Port and this makes OVN thinks that
both addresses are associated to the same Node, but that might
not always be true as keepalived can put them in separate Nodes.
To change that, let's make sure the API VIPs stays together through
state changes, the same goes for Ingress VIPs.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 16, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered searching for bug OCPBUGS-53248 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #4923

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mandre and rvanderp3 April 16, 2025 13:02
@MaysaMacedo
Copy link
Contributor

/hold

@mandre hey, before merging this PR let's make sure upgrade to the versions that has this fix continues working.
Feel free to remove the hold when that is verified.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2025
@imatza-rh
Copy link

/hold

@mandre hey, before merging this PR let's make sure upgrade to the versions that has this fix continues working. Feel free to remove the hold when that is verified.

Upgrade tests passed. I think we can remove the hold.
Please check my comment here - https://issues.redhat.com/browse/OCPBUGS-53248?focusedId=27028031&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27028031

mandre
mandre reviewed Apr 22, 2025
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2025
mandre
mandre reviewed Apr 22, 2025
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 22, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mandre, openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign jkyros for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rlobillo
Copy link

rlobillo commented May 7, 2025

/recheck

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 7, 2025
@rlobillo
Copy link

rlobillo commented May 7, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a3c095e link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade a3c095e link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-gcp-op a3c095e link false /test okd-scos-e2e-gcp-op
ci/prow/e2e-aws-ovn-upgrade a3c095e link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@rbbratta rbbratta

@eurijon eurijon

@zhaozhanqi zhaozhanqi

@MaysaMacedo MaysaMacedo

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels
backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.