Switch to canonical json-patch v4 import #1923
Conversation
skitt
force-pushed
the
canonical-json-patch
branch
from
feee9e9 to
c372611
Compare
This matches k/k upstream, see kubernetes/kubernetes#123339 for details. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
canonical-json-patch
branch
from
c372611 to
42b9735
Compare
|
@bertinatto what would the process be to get this and #1924 reviewed? Should I open JIRA issues? |
|
@skitt: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Makes sense to me, this matches 4.19:
https://github.com/openshift/kubernetes/blob/release-4.19/go.mod#L94
Also, I don't see any code changes in the vendor directory, just an import in one of our packages (which is good).
We had problems with this package being inadvertently updated and importing breaking changes, so fixing the import makes sense.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This matches k/k upstream, see
kubernetes/kubernetes#123339 for details.