Skip to content

WIP: Experiment with enabling VolumeAttributesClass tests #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented May 6, 2025

Copy [FeatureGate:VolumeAttributesClass] to [OCPFeatureGate:VolumeAttributesClass], hoping that openshift-tests will filter OCPFeatureGate: tests according to feature gates enabled in the test cluster.

Remove all rules about [Feature:VolumeAttributesClass], they're useless now.

This is only proof of concept. IMHO, teaching openshift-tests to parse both [OCPFeatureGate:xyz] and [FeatureGate:xyz] is a better path forward.

dfajmon and others added 2 commits May 6, 2025 14:28
To be included in e2e jobs where the feature gate is set and skipped
otherwise.
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 6, 2025
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
Copy link

openshift-ci bot commented May 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jsafrane
Copy link
Author

jsafrane commented May 6, 2025

/test e2e-gcp

@jsafrane
Copy link
Author

jsafrane commented May 6, 2025

/test help

Copy link

openshift-ci bot commented May 6, 2025

@jsafrane: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test artifacts
/test configmap-scale
/test e2e-aws-crun-wasm
/test e2e-aws-jenkins
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-crun
/test e2e-aws-ovn-downgrade
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-runc
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-ovn-upgrade
/test images
/test integration
/test k8s-e2e-conformance-aws
/test k8s-e2e-gcp-ovn
/test k8s-e2e-gcp-serial
/test perfscale-control-plane-6nodes
/test unit
/test verify
/test verify-commits

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-ovn
/test e2e-aws-single-node
/test e2e-azure
/test e2e-external-aws-ccm
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-csi-cinder
/test e2e-openstack-csi-manila
/test e2e-vsphere
/test k8s-e2e-aws
/test k8s-e2e-aws-ovn-serial
/test k8s-e2e-gcp-five-control-plane-replicas
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-kubernetes-master-artifacts
pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd
pull-ci-openshift-kubernetes-master-e2e-aws-crun-wasm
pull-ci-openshift-kubernetes-master-e2e-aws-csi
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-hypershift
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-runc
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-master-e2e-gcp
pull-ci-openshift-kubernetes-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-kubernetes-master-images
pull-ci-openshift-kubernetes-master-integration
pull-ci-openshift-kubernetes-master-k8s-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-ovn
pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
pull-ci-openshift-kubernetes-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-kubernetes-master-unit
pull-ci-openshift-kubernetes-master-verify
pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign benluddy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Author

jsafrane commented May 6, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

Copy link

openshift-ci bot commented May 6, 2025

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/57f419f0-2a79-11f0-9cf4-8508b46f734b-0

@jsafrane
Copy link
Author

jsafrane commented May 6, 2025

/test e2e-aws-ovn

Copy link

openshift-ci bot commented May 6, 2025

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn b434ee5 link false /test e2e-aws-ovn
ci/prow/e2e-gcp b434ee5 link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Author

/payload-job periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-periodics-e2e-vsphere-periodic-techpreview
Just testing the job, unrelated to this PR.

Copy link

openshift-ci bot commented May 12, 2025

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-periodics-e2e-vsphere-periodic-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/065f3090-2f31-11f0-9184-3bcbad4173a0-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants