-
Notifications
You must be signed in to change notification settings - Fork 117
WIP: Experiment with enabling VolumeAttributesClass tests #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
To be included in e2e jobs where the feature gate is set and skipped otherwise.
@jsafrane: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Skipping CI for Draft Pull Request. |
/test e2e-gcp |
/test help |
@jsafrane: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview |
@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/57f419f0-2a79-11f0-9cf4-8508b46f734b-0 |
/test e2e-aws-ovn |
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/payload-job periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-periodics-e2e-vsphere-periodic-techpreview |
@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/065f3090-2f31-11f0-9184-3bcbad4173a0-0 |
Copy
[FeatureGate:VolumeAttributesClass]
to[OCPFeatureGate:VolumeAttributesClass]
, hoping thatopenshift-tests
will filterOCPFeatureGate:
tests according to feature gates enabled in the test cluster.Remove all rules about
[Feature:VolumeAttributesClass]
, they're useless now.This is only proof of concept. IMHO, teaching
openshift-tests
to parse both[OCPFeatureGate:xyz]
and[FeatureGate:xyz]
is a better path forward.