WIP: OCPBUGS-42087: Add metric for watch cache ready #2234
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit |
openshift-ci
bot
added
the
approved
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-agent-ha-dualstack-conformance |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/02f89670-f9fe-11ef-9ec0-fbf3c911d7f8-0 |
bertinatto
force-pushed
the
add-metric-watch-cache-ready
branch
from
c554029 to
c918fbd
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test unit |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.19-e2e-agent-ha-dualstack-conformance 10 |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9632c640-fa12-11ef-8131-8a670409c226-0 |
|
/test all |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.19-e2e-agent-ha-dualstack-conformance 10 |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34b8a8e0-fa66-11ef-9ce9-a0295b05f037-0 |
bertinatto
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@bertinatto: This pull request references Jira Issue OCPBUGS-42087, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
| @@ -46,6 +48,7 @@ type ready struct { | |||
| } | |||
|
|
|||
| func newReady() *ready { | |||
| metrics.RecordWatchCacheReady(false) | |||
There was a problem hiding this comment.
I think I would add this metric somewhere here
and for the off scenario somewhere here
We could slightly change WatchCacheInitializations to be a gauge or depreciate it and create a new one. I think the latter is better.
bertinatto
force-pushed
the
add-metric-watch-cache-ready
branch
from
c918fbd to
8d16ff5
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
bertinatto
force-pushed
the
add-metric-watch-cache-ready
branch
from
8d16ff5 to
ccee3e5
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
…eature" This reverts commit 4772890.
bertinatto
force-pushed
the
add-metric-watch-cache-ready
branch
from
ccee3e5 to
4cb7ce0
Compare
|
@bertinatto: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.19-e2e-agent-ha-dualstack-conformance 10 |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e6ceb6f0-fabb-11ef-97c5-bbe9b53996a1-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-agent-ha-dualstack-conformance openshift/cluster-kube-apiserver-operator#1822 |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43c75840-fb83-11ef-91e3-6f93d0dd99c7-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-agent-ha-dualstack-conformance openshift/cluster-kube-apiserver-operator#1822 |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60593840-fcfd-11ef-9307-680c8b7be18c-0 |
|
/test all |
|
@bertinatto: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test ? |
|
@bertinatto: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-agent-ha-dualstack-conformance openshift/cluster-kube-apiserver-operator#1822 |
|
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26429e30-fdb6-11ef-92aa-4b9be638d605-0 |
No description provided.