OCPBUGS-43330: BMO never mounted dataimage into IBI provisioned SNO #141
Conversation
There's a race between the DataImage creation and the reboot annotation added in updateBMHProvisioningState This PR adds a check that the DataImage creationTimestamp is more than the DataImageCoolDownPeriod ago (set to 1 second by default). In case the the dataImage was created withing the DataImageCoolDownPeriod the controller will return early and requeue the ICI CR after the DataImageCoolDownPeriod. This should prevent IBIO from adding the reboot annotation before BMO cached client notice that a DataImage exists. Signed-off-by: Eran Cohen <[email protected]>
openshift-ci-robot
added
jira/valid-reference
|
@tsorya: This pull request references Jira Issue OCPBUGS-43330, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
What's the difference between this and #140? |
|
@tsorya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There's a race between the DataImage creation and the reboot annotation added in updateBMHProvisioningState This PR adds a check that the DataImage creationTimestamp is more than the DataImageCoolDownPeriod ago (set to 1 second by default). In case the the dataImage was created withing the DataImageCoolDownPeriod the controller will return early and requeue the ICI CR after the DataImageCoolDownPeriod. This should prevent IBIO from adding the reboot annotation before BMO cached client notice that a DataImage exists.