Skip to content

OCPNODE-2929: proposal of OCI image volume #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPNODE-2929: proposal of OCI image volume #1792

wants to merge 1 commit into from

Conversation

bitoku
Copy link

@bitoku bitoku commented May 7, 2025

/assign haircommander
/assign saschagrunert

This is a proposal for how to integrate OCI image volume into OpenShift.

@openshift-ci openshift-ci bot requested review from coverprice and jaypoulz May 7, 2025 18:23
@bitoku bitoku force-pushed the oci-image-volume branch from 4c88477 to 346b211 Compare May 7, 2025 18:31
@bitoku
Copy link
Author

bitoku commented May 7, 2025

/cc mrunalp

@openshift-ci openshift-ci bot requested a review from mrunalp May 7, 2025 18:56
@bitoku bitoku force-pushed the oci-image-volume branch from 346b211 to ec6b9a3 Compare May 8, 2025 10:52
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2025

@bitoku: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

saschagrunert
saschagrunert reviewed May 8, 2025
View reviewed changes
enhancements/kubelet/oci-image-volume.md

#### OCI Artifact

While OCI artifact is in dev preview, it fails to mount if a user specifies OCI artifact in reference. To enable the mount, users need to add this drop-in CRI-O configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should call it dev preview, which may imply that we change the OpenShift API. We can just state that it has to be manually enabled once proven to be stable in CRI-O.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar discussion https://redhat-internal.slack.com/archives/GK6BJJ1J5/p1745584306680429 .
@haircommander wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so dev preview seems fine to my understanding now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I typically use Dev Preview as a shorthand for not in the API yet

saschagrunert
saschagrunert approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bitoku
Copy link
Author

bitoku commented May 12, 2025

@mrunalp @haircommander PTAL for approval.

@bitoku bitoku changed the title Add initial proposal of OCI image volume OCPNODE-2929: proposal of OCI image volume May 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@bitoku: This pull request references OCPNODE-2929 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

/assign haircommander
/assign saschagrunert

This is a proposal for how to integrate OCI image volume into OpenShift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@coverprice coverprice Awaiting requested review from coverprice

@jaypoulz jaypoulz Awaiting requested review from jaypoulz

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bitoku @openshift-ci-robot @haircommander @saschagrunert