Skip to content

OPRUN-3767: Add OLMv1 Single/OwnNamespace EP #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thetechnick
Copy link

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lmzuccarelli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

OLMv0 offered multiple install modes (AllNamespaces, MultiNamespace, SingleNamspace, OwnNamespace). These install modes are an implementation detail of OLMv0 support for multi-tenancy, to allow the installation of the same operator multiple times on the same cluster.

Because OLMv0 multi-tenancy features have been the source of a wide variety of problems, OLMv1 made a deliberate decision to not implement the same mechanisms.
Today OLMv1 only supports operator bundles who chose the AllNamespaces installMode.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Today OLMv1 only supports operator bundles who chose the AllNamespaces installMode.
Today OLMv1 only supports operator bundles who support the AllNamespaces installMode.

However, customers are looking for SingleNamespace and OwnNamespace installmode. Here are some use cases for this:

- Due to isolation concerns, some operators prefer to not support AllNamespaces installMode
- Customers have existing OLM V0 operators which are support singleNamespace and OwnNamespace installmode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having trouble parsing this one. Having a stab at it:

Suggested change
- Customers have existing OLM V0 operators which are support singleNamespace and OwnNamespace installmode
- Customers have existing OLM V0 operators which only support SingleNamespace and OwnNamespace installmode

- Due to isolation concerns, some operators prefer to not support AllNamespaces installMode
- Customers have existing OLM V0 operators which are support singleNamespace and OwnNamespace installmode

This Brief outlines how OLMv1 can be compatible with OLMv0 Single- and OwnNamespace installModes, without re-introducing problematic multi-tenancy features.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This Brief outlines how OLMv1 can be compatible with OLMv0 Single- and OwnNamespace installModes, without re-introducing problematic multi-tenancy features.
This enhancement proposal outlines how OLMv1 can be compatible with OLMv0 Single- and OwnNamespace installModes, without re-introducing problematic multi-tenancy features.

Comment on lines +132 to +136
- User can configure registry+v1 bundle installation mode through the ClusterExtension API
- API reviewed and approved by API review Gods
- User can install a registry+v1 bundle in SingleNamespace mode
- User can install a registry+v1 bundle in OwnNamespace mode
- Additional testing ensures generated content is inline with what v0 produces (i.e. user’s expectations won’t be violated), and we are confident future changes to the RukPak package won’t cause behavioral regressions

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- User can configure registry+v1 bundle installation mode through the ClusterExtension API
- API reviewed and approved by API review Gods
- User can install a registry+v1 bundle in SingleNamespace mode
- User can install a registry+v1 bundle in OwnNamespace mode
- Additional testing ensures generated content is inline with what v0 produces (i.e. user’s expectations won’t be violated), and we are confident future changes to the RukPak package won’t cause behavioral regressions
- User can configure their desired registry+v1 bundle installation mode through the ClusterExtension API
- User can install a registry+v1 bundle in SingleNamespace mode - if the bundle supports it
- User can install a registry+v1 bundle in OwnNamespace mode - if the bundle supports it
- Additional testing ensures generated content is inline with what v0 produces (i.e. user’s expectations won’t be violated), and we are confident future changes to the registry+v1 rendering package won’t cause behavioral regressions

@jianzhangbjz
Copy link

jianzhangbjz commented Apr 17, 2025

/retitle OPRUN-3767: Add OLMv1 Single/OwnNamespace EP

@openshift-ci openshift-ci bot changed the title Add OLMv1 Single/OwnNamespace EP OPRUN-3767: Add OLMv1 Single/OwnNamespace EP Apr 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025

@thetechnick: This pull request references OPRUN-3767 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants