CONSOLE-4484: Replace custom tabs with PF6 Tabs component

[logonoff]

fixes https://issues.redhat.com/browse/CONSOLE-4484

before/after:

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4484 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

fixes https://issues.redhat.com/browse/CONSOLE-4484

before/after:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/label acknowledge-critical-fixes-only

code review:
/assign @rhamilto

QE review:
/assign @yapei

Adding labels for PF6 follow on
/label docs-approved
/label px-approved

[logonoff]

this is another orphaned file, so I removed it

[logonoff]

ccing PatternFly team as well if they want to take a look

/cc nicolethoen kmcfaul

[openshift-ci]

@logonoff: GitHub didn't allow me to request PR reviews from the following users: kmcfaul.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

ccing PatternFly team as well if they want to take a look

/cc nicolethoen kmcfaul

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yapei]

• We also need some changes on alertmanager tests and view files

For tests file under frontend/packages/integration-tests-cypress/tests/cluster-settings/alertmanager folder

detailsPage.selectTab('yaml') occurrence should be updated to detailsPage.selectTab('YAML')
detailsPage.selectTab('details'); occurrence should be updated to detailsPage.selectTab('Details');

For view file frontend/packages/integration-tests-cypress/views/alertmanager.ts

  visitYAMLPage: () => {
    detailsPage.selectTab('yaml');
    yamlEditor.isLoaded();
  }

detailsPage.selectTab('yaml'); should be updated to detailsPage.selectTab('YAML')

[yapei]

Observe - Alerting tabs are not properly rendered

how it looks on 4.19.0-0.nightly-2025-02-13-160033

[logonoff]

Observe - Alerting tabs are not properly rendered

how it looks on 4.19.0-0.nightly-2025-02-13-160033

I see -- lots of dynamic plugins depend on co-m-horizontal-nav, but I removed the CSS for it.

We previously stated that CSS classes aren't officially supported by the dynamic plugin API, but given the opportunity for breakage, we might want to keep the classes until 4.20.

@rhamilto @jhadvig wdyt?

[logonoff]

@yapei we discussed in standup that we would remove the CSS for co-m-horizontal-nav anyway and add it as a breaking change for dynamic plugins, since a bunch of other breaking changes are going to be made in 4.19 (e.g., the removal of HTML heading styles). the recommendation for plugins is to use PF6 or PF5 Tabs depending on whether they need the backwards compatibility

/remove-label docs-approved

updated dynamic plugin SDK README to include a new breaking change

/assign @opayne1

[yapei]

/retest-required

[yapei]

/retest-required

[logonoff]

/retest

[yapei]

tested the new changes and working well
/label qe-approved

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4484 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

fixes https://issues.redhat.com/browse/CONSOLE-4484

before/after:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhadvig]

Thanks @logonoff !!! You simple the best 👑
/lgtm
/approve

[jhadvig]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[opayne1]

/label docs-approved

[openshift-ci]

New changes are detected. LGTM label has been removed.