POC

openshift · Feb 13, 2025 · 8ff16de · 8ff16de
1 parent 1c061f5
commit 8ff16de
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/frontend/public/components/masthead.jsx b/frontend/public/components/masthead.jsx
@@ -40,7 +40,7 @@ export const Masthead = React.memo(({ isMastheadStacked, isNavOpen, onNavToggle
         <MastheadBrand>
           <MastheadLogo
             component="a"
-            aria-label={window.SERVER_FLAGS.customLogoURL ? undefined : details.productName}
+            aria-label={details.productName}
             data-test="masthead-logo"
             {...logoProps}
           >

diff --git a/frontend/public/imgs/github-dark.png b/frontend/public/imgs/github-dark.png
diff --git a/frontend/public/imgs/github.png b/frontend/public/imgs/github.png
diff --git a/frontend/public/index.html b/frontend/public/index.html
@@ -7,6 +7,8 @@
     [[ if .ServerFlags.CustomProductName ]]
     <title>[[ .ServerFlags.CustomProductName ]]</title>
     <meta name="application-name" content="[[ .ServerFlags.CustomProductName ]]" />
+    <!-- put this in a separate if statement -->
+    <link rel="shortcut icon" href="<%= require('./imgs/github.png') %>" />
     [[ else ]] [[ if eq .ServerFlags.Branding "okd" ]]
     <title>OKD</title>
     <meta name="application-name" content="OKD" />
@@ -66,6 +68,11 @@
       }
       if (theme === 'dark') {
         document.documentElement.classList.add('pf-v6-theme-dark', 'pf-v5-theme-dark'); // legacy pf-theme-dark class needed for PF5 component styling
+        // put this in a unique if statement
+        [[ if .ServerFlags.CustomProductName ]]
+        var link = document.querySelector("link[rel~='icon']");
+        link.href = '<%= require("./imgs/github-dark.png") %>';
+        [[ end ]]
       }
     </script>
   </head>