OCPBUGS-49921: fix run time error when no completed version exists

openshift · Feb 10, 2025 · 83f4c3f · 83f4c3f
1 parent 24ccf7a
commit 83f4c3f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/frontend/public/components/cluster-settings/cluster-settings.tsx b/frontend/public/components/cluster-settings/cluster-settings.tsx
@@ -219,7 +219,7 @@ export const CurrentVersion: React.FC<CurrentVersionProps> = ({ cv }) => {
           {lastVersion}
         </span>
       </div>
-      <ReleaseNotesLink version={getLastCompletedUpdate(cv)} />
+      <ReleaseNotesLink version={lastVersion} />
     </>
   ) : (
     <>{t('public~None')}</>
@@ -587,9 +587,8 @@ export const UpdatesGraph: React.FC<UpdatesGraphProps> = ({ cv }) => {
   const availableUpdates = getSortedAvailableUpdates(cv);
   const lastVersion = getLastCompletedUpdate(cv);
   const newestVersion = availableUpdates[0]?.version;
-  const minorVersionIsNewer = newestVersion
-    ? isMinorVersionNewer(lastVersion, newestVersion)
-    : false;
+  const minorVersionIsNewer =
+    lastVersion && newestVersion ? isMinorVersionNewer(lastVersion, newestVersion) : false;
   const secondNewestVersion = availableUpdates[1]?.version;
   const currentChannel = cv.spec.channel;
   const currentPrefix = splitClusterVersionChannel(currentChannel)?.prefix;

diff --git a/frontend/public/module/k8s/cluster-settings.ts b/frontend/public/module/k8s/cluster-settings.ts
@@ -85,6 +85,9 @@ export const getSortedNotRecommendedUpdates = (cv: ClusterVersionKind): Conditio
 
 export const getNewerMinorVersionUpdate = (currentVersion, availableUpdates) => {
   const currentVersionParsed = semver.parse(currentVersion);
+  if (!currentVersionParsed) {
+    return;
+  }
   return availableUpdates?.find(
     // find the next minor version update, which there should never be more than one
     (update) => {
@@ -101,8 +104,8 @@ export const isMinorVersionNewer = (currentVersion, otherVersion) => {
   const currentVersionParsed = semver.parse(currentVersion);
   const otherVersionParsed = semver.parse(otherVersion);
   return semver.gt(
-    semver.coerce(`${otherVersionParsed.major}.${otherVersionParsed.minor}`),
-    semver.coerce(`${currentVersionParsed.major}.${currentVersionParsed.minor}`),
+    semver.coerce(`${otherVersionParsed?.major}.${otherVersionParsed?.minor}`),
+    semver.coerce(`${currentVersionParsed?.major}.${currentVersionParsed?.minor}`),
   );
 };