OTA-1010: Add a new version of GetImplicitlyEnabledCapabilities

[hongkailiu]

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep the function here temporarily to ensure it works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep it function here temporarily to ensure the signature of the function works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep it function here temporarily to ensure the function works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add a new version of GetImplicitlyEnabledCapabilities that is going to be lifted to library-go.

At the moment, we keep the function here temporarily to ensure it works for CVO.
We should also keep it in mind once it goes to library-go, the function should be also usable for oc-cli, e.g., the extract command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hongkailiu]

/hold

Will rebase after #1159 gets in.

[hongkailiu]

/test images

[hongkailiu]

/retest-required

[hongkailiu]

/retest-required
/hold cancel

[hongkailiu]

/test okd-scos-e2e-aws-ovn

[hongkailiu]

/test okd-scos-e2e-aws-ovn

[openshift-ci]

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	9cdc271	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[DavidHurta]

/uncc
I am under the impression that Trevor will have a look. Ping me if needed.

[petr-muller]

How do we test this implementation is:

1. Correct?
2. Equivalent to the deleted GetImplicitlyEnabledCapabilities?

For (1) I assume that we'll need tests once we lift it to o/library-go so why not write them right away?
For (2) I wonder if if would be proper to keep the old implementation for a while, implement a test that shows that the two implementations are equivalent (same inputs -> same outputs) and only delete the code (and the equivalence test) once the o/library-go implementation fully settles?

[hongkailiu]

For (2): There are tests for it already.

cluster-version-operator/pkg/payload/payload_test.go

Line 220 in 198fdab

func TestGetImplicitlyEnabledCapabilities(t *testing.T) {

At least, from those tests point of view, they are equivalent.

For (1):

I moved over the unit tests from (2) to https://github.com/openshift/library-go/pull/1908/files with modifications

• to fit the new function signature (added a new arg manifestInclusionConfiguration), and
• to avoid copying testdata/payloadcapabilitytest there and convincing o/lib approvers that it OK to do it .

[petr-muller]

Ah okay, we have tests on the payload-level GetImplicitlyEnabledCapabilities which calls the new function, good!

then

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment