METAL-1053: Remove baremetal dependency on MachineAPI capability #1064
Conversation
go get -u github.com/openshift/api@master go mod tidy go mod vendor git add -A go.* vendor Get featuregate definitions from api/features instead of api/config/v1 Updted library-go to latest This is required due to the FeatureSets changes in openshift/api Catching up with the YAML getting shifted into a subdirectory [1]. I followed the new docs from [2] to create pkg/dependencymagnet Skip render for DevPreviewNoUpgrade The Default ClusterVersion CRD is the one we want to render during bootstrap-render Update ./hack/test-prerequisites.go to pick up clusterversion crds from the new path config/v1/zz_generated.crd-manifests [1]: openshift/api#1814 [2]: openshift/api@06baaa4#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R211 Signed-off-by: Eran Cohen <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
eranco74
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@eranco74: This pull request references METAL-1053 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@eranco74: This pull request references METAL-1053 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-techpreview |
|
@eranco74: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c0f3a800-36bc-11ef-869c-10d729634e07-0 |
…rom the new path config/v1/zz_generated.crd-manifests Signed-off-by: Eran Cohen <[email protected]>
|
/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-techpreview |
|
@eranco74: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/518ee3a0-36c9-11ef-90a9-317bdce50152-0 |
|
@eranco74: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
closing in favor of #1045 |
vendor: bump openshift/api
go get -u github.com/openshift/api@master
go mod tidy
go mod vendor
git add -A go.* vendor
Get featuregate definitions from api/features instead of api/config/v1 Updted library-go to latest
This is required due to the FeatureSets changes in openshift/api
Catching up with the YAML getting shifted into a subdirectory 1. I followed the new docs from 2 to create pkg/dependencymagnet Skip render for DevPreviewNoUpgrade
The Default ClusterVersion CRD is the one we want to render during bootstrap-render
Update ./hack/test-prerequisites.go to pick up clusterversion crds from the new path config/v1/zz_generated.crd-manifests