OCPBUGS-55285: bindata,ovn-k,cudn: Validate loclanet topology's excludeSubnet match specified subnets

[ormergi]

Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure the specified excludeSubnetes match the specified subnets.

Note to reviewer:
This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet.

Once the fix is available on U/S, the CRD definition in OVN-Kubentes repo should have the same CEL validation this PR adds, tracked by [4].

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267
[4] ovn-kubernetes/ovn-kubernetes#5195

[openshift-ci-robot]

@ormergi: This pull request references CORENET-5358 which is a valid jira issue.

In response to this:

Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure the specified excludeSubnetes match the specified subnets.

This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet.

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ormergi: This pull request references CORENET-5358 which is a valid jira issue.

In response to this:

Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure the specified excludeSubnetes match the specified subnets.

This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet.

Once the fix is available on U/S, the CRD definition in OVN-Kubentes repo should have the same CEL validation this PR adds, tracked by [4].

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267
[4] ovn-kubernetes/ovn-kubernetes#5195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ormergi: This pull request references CORENET-5358 which is a valid jira issue.

In response to this:

Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure the specified excludeSubnetes match the specified subnets.

Note to reviewer:
This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet.

Once the fix is available on U/S, the CRD definition in OVN-Kubentes repo should have the same CEL validation this PR adds, tracked by [4].

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267
[4] ovn-kubernetes/ovn-kubernetes#5195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ormergi]

Verified on ephemeral cluster built with this PR changes (using cluster-bot), using the attached CUDN YAMLs
test-cudn-exclude-subnet-validtion.md
The validation work as expected:

$ oc apply -f test-cudn-exclude-subnet-validtion.md 
clusteruserdefinednetwork.k8s.ovn.org/localnet-match-exsubnets-masked-cidrs-should-succeed created
clusteruserdefinednetwork.k8s.ovn.org/localnet-match-exsubnets-unmasked-cidrs-should-succeed created
Error from server (Invalid): error when creating "test-cudn-exclude-subnet-validtion.md": ClusterUserDefinedNetwork.k8s.ovn.org "localnet-missmatch-exsubnets-masked-cidrs-should-fail" is invalid: spec.network.localnet.excludeSubnets: Invalid value: "object": excludeSubnets must be subnetworks of the networks specified in the subnets field
Error from server (Invalid): error when creating "test-cudn-exclude-subnet-validtion.md": ClusterUserDefinedNetwork.k8s.ovn.org "localnet-missmatch-exsubnets-unmasked-cider-should-fail" is invalid: spec.network.localnet.excludeSubnets: Invalid value: "object": excludeSubnets must be subnetworks of the networks specified in the subnets field

[ormergi]

/cc @kyrtapz @tssurya @ricky-rav

[ormergi]

ci/prow/e2e-aws-ovn-windows failed due to known issue

e2e-gcp-ovn-techpreview - 1 test failed due to issue that doesnt seem related to this PR changes.

/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-ipsec-upgrade
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-ovn-ipsec-step-registry

[ricky-rav]

/LGTM
Thanks, Or!

[ormergi]

e2e-aws-ovn-ipsec-upgrade & e2e-ovn-ipsec-step-registry failed because env failed to create on time

 level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: infrastructure was not ready within 15m0s: client rate limiter Wait returned an error: context deadline exceeded 

/test e2e-aws-ovn-ipsec-upgrade
/test e2e-ovn-ipsec-step-registry

[ricky-rav]

/retitle OCPBUGS-55285: bindata,ovn-k,cudn: Validate loclanet topology's excludeSubnet match specified subnets

[openshift-ci-robot]

@ormergi: This pull request references Jira Issue OCPBUGS-55285, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure the specified excludeSubnetes match the specified subnets.

Note to reviewer:
This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet.

Once the fix is available on U/S, the CRD definition in OVN-Kubentes repo should have the same CEL validation this PR adds, tracked by [4].

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267
[4] ovn-kubernetes/ovn-kubernetes#5195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ricky-rav]

/jira refresh

[openshift-ci-robot]

@ricky-rav: This pull request references Jira Issue OCPBUGS-55285, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ormergi]

e2e-aws-ovn-ipsec-upgrade failed at setup phase

 level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: infrastructure was not ready within 15m0s: context deadline exceeded 

e2e-metal-ipi-ovn-ipv6-ipsec failed to setup the tests cluster:

 Error from server (ServiceUnavailable): the server is currently unable to handle the request (get imagestreams.image.openshift.io)
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-04-23T17:48:04Z"}
error: failed to execute wrapped command: exit status 1

/test e2e-aws-ovn-ipsec-upgrade
/test e2e-metal-ipi-ovn-ipv6-ipsec

[ormergi]

/test e2e-aws-ovn-ipsec-upgrade
/test e2e-metal-ipi-ovn-ipv6-ipsec

[ormergi]

/test e2e-gcp-ovn-techpreview

[ormergi]

/test e2e-aws-ovn-ipsec-upgrade
/test e2e-metal-ipi-ovn-ipv6-ipsec

[kyrtapz]

/lgtm

[kyrtapz]

/override ci/prow/e2e-aws-ovn-windows

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, ormergi, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ormergi]

/test e2e-metal-ipi-ovn-ipv6-ipsec

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 558108a and 2 for PR HEAD 197d806 in total

[ormergi]

/test e2e-metal-ipi-ovn-ipv6-ipsec

[kyrtapz]

/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

[openshift-ci]

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kyrtapz]

e2e-aws-ovn-upgrade failed on an unrelated test
/override ci/prow/e2e-aws-ovn-upgrade

e2e-aws-ovn-ipsec-upgrade is perma failing, tracked here: https://issues.redhat.com/browse/OCPBUGS-55262
/override ci/prow/e2e-aws-ovn-ipsec-upgrade

e2e-aws-ovn-hypershift-conformance failed for unrelated reasons and it passed before
/override ci/prow/e2e-aws-ovn-hypershift-conformance

[openshift-ci]

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-ovn-ipsec-upgrade, ci/prow/e2e-aws-ovn-upgrade

In response to this:

e2e-aws-ovn-upgrade failed on an unrelated test
/override ci/prow/e2e-aws-ovn-upgrade

e2e-aws-ovn-ipsec-upgrade is perma failing, tracked here: https://issues.redhat.com/browse/OCPBUGS-55262
/override ci/prow/e2e-aws-ovn-ipsec-upgrade

e2e-aws-ovn-hypershift-conformance failed for unrelated reasons and it passed before
/override ci/prow/e2e-aws-ovn-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@ormergi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade	197d806	link	false	/test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/e2e-vsphere-ovn	197d806	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-dualstack	197d806	link	false	/test e2e-vsphere-ovn-dualstack
ci/prow/e2e-aws-hypershift-ovn-kubevirt	197d806	link	false	/test e2e-aws-hypershift-ovn-kubevirt
ci/prow/security	197d806	link	false	/test security
ci/prow/e2e-openstack-ovn	197d806	link	false	/test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node	197d806	link	false	/test e2e-aws-ovn-single-node
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	197d806	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade	197d806	link	false	/test 4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ormergi: Jira Issue OCPBUGS-55285: All pull requests linked via external trackers have merged:

• openshift/cluster-network-operator#2692

Jira Issue OCPBUGS-55285 has been moved to the MODIFIED state.

In response to this:

Add CEL validation on OVN-K CUDN CRD for localnet to topology, to ensure the specified excludeSubnetes match the specified subnets.

Note to reviewer:
This change make the CRD diverge from the CRD on U/S due to a bug [1] that its fix is available on D/S [2] [3] but not available on U/S yet.

Once the fix is available on U/S, the CRD definition in OVN-Kubentes repo should have the same CEL validation this PR adds, tracked by [4].

[1] https://issues.redhat.com/browse/OCPBUGS-54426
[2] openshift/kubernetes#2263
[3] openshift/kubernetes#2267
[4] ovn-kubernetes/ovn-kubernetes#5195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.20.0-202504251429.p0.g2a1d615.assembly.stream.el9.
All builds following this will include this PR.