Skip to content

OCPBUGS-55217: Optimistically update Kube Server and Client CA bundles #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

OCPBUGS-55217: Optimistically update Kube Server and Client CA bundles #1812

wants to merge 2 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Feb 19, 2025 •
edited
Loading

Instead of re-creating configmap from scratch every time this function should attempt to use existing configmap and replace the contents only. This would prevent extra configmap updates when metadata changes.

Bump library-go to update openshift/library-go#1936

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs vrutkovs mentioned this pull request Feb 19, 2025
Open
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn e2e-aws-ovn-upgrade

@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from 37e7ae2 to 1134c0e Compare February 19, 2025 07:50
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn e2e-aws-ovn-upgrade

1 similar comment
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn e2e-aws-ovn-upgrade

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025
@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from 1134c0e to 42120ad Compare April 22, 2025 08:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@vrutkovs: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96073a70-1f56-11f0-993f-3123e6123385-0

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs vrutkovs changed the title Optimistically update Kube Server and Client CA bundles OCPBUGS-55217: Optimistically update Kube Server and Client CA bundles Apr 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 22, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-55217, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Tests we run after cert rotation should ensure that pod gets created
from deployment, scheduled on the node and openshift-apiserver can
create projects to validate that all component certificates have been
regenerated. The test names are included in
certificates.openshift.io/auto-regenerate-after-offline-expiry annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 April 22, 2025 12:41
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-55217, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Instead of re-creating configmap from scratch every time this function should attempt to use existing configmap and replace the contents only. This would prevent extra configmap updates when metadata changes.

Bump library-go to update openshift/library-go#1936

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from 42120ad to 1998001 Compare April 24, 2025 08:42
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

6 similar comments
@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@vrutkovs
Copy link
Member Author

vrutkovs commented May 5, 2025

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from 1998001 to 507e21c Compare May 6, 2025 09:02
@vrutkovs
Copy link
Member Author

vrutkovs commented May 6, 2025

/test e2e-aws-ovn

1 similar comment
@vrutkovs
Copy link
Member Author

vrutkovs commented May 6, 2025

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from bf024d9 to b8c15b8 Compare May 6, 2025 16:47
@vrutkovs
Copy link
Member Author

vrutkovs commented May 6, 2025

/test e2e-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2025 •
edited
Loading

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps 1134c0e link true /test verify-deps
ci/prow/unit 1134c0e link true /test unit
ci/prow/e2e-aws-ovn-serial 1134c0e link true /test e2e-aws-ovn-serial
ci/prow/okd-scos-images 1134c0e link true /test okd-scos-images
ci/prow/images 1134c0e link true /test images
ci/prow/verify 1134c0e link true /test verify
ci/prow/k8s-e2e-gcp 1134c0e link true /test k8s-e2e-gcp
ci/prow/e2e-aws-ovn-upgrade 1134c0e link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-operator 1134c0e link true /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from b8c15b8 to 52f9880 Compare May 7, 2025 06:26
@vrutkovs
Copy link
Member Author

vrutkovs commented May 7, 2025

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from 52f9880 to d0fdec8 Compare May 7, 2025 09:35
@vrutkovs
Copy link
Member Author

vrutkovs commented May 7, 2025

/test e2e-aws-ovn

@vrutkovs vrutkovs force-pushed the cert-rotation-annotations-cas-devel branch from d0fdec8 to 4fd3cc1 Compare May 13, 2025 14:08
@vrutkovs
Copy link
Member Author

/test e2e-short-cert-rotation e2e-aws-ovn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrutkovs @openshift-ci-robot @openshift-merge-robot