Skip to content

library-go certrotation: avoid using applySecret to catch racy cert updates #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Aug 2, 2024

Alternative for openshift/library-go#1722

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2024
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 2, 2024

/test e2e-aws-ovn e2e-gcp-operator

Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 5, 2024

/test e2e-aws-ovn e2e-gcp-operator

@vrutkovs vrutkovs force-pushed the cert-rotation-avoid-applySecret branch from 37b6103 to 3ab4efa Compare August 5, 2024 06:46
@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 5, 2024

/test e2e-aws-ovn e2e-gcp-operator

@vrutkovs vrutkovs force-pushed the cert-rotation-avoid-applySecret branch from 3ab4efa to a064569 Compare August 5, 2024 10:45
@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 5, 2024

/test e2e-aws-ovn e2e-gcp-operator

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn a064569 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-operator a064569 link true /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrutkovs vrutkovs closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants