-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19026: Add authentication support for refresh token of ocm-cli #2540
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dudyas6 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dudyas6: This pull request references MGMT-19026 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test it locally ?
@@ -193,3 +193,5 @@ IMAGES_FLAVOR | |||
SERVICE_ACCOUNT_CLIENT_ID | |||
SERVICE_ACCOUNT_CLIENT_SECRET | |||
OCM_SELF_TOKEN | |||
OCM_CLI_REFRESH_TOKEN | |||
SECOND_OCM_CLI_REFRESH_TOKEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In kni-assisted repo we have this
SECOND_OFFLINE_TOKEN = utils.get_env('SECOND_OFFLINE_TOKEN') SECOND_PULL_SECRET = utils.get_env('SECOND_PULL_SECRET')
Since offline token is deprecated, we will need a second ocm token.
/hold |
/unhold |
@dudyas6: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@danmanor tested locally that all 3 options are working |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR is to add the option to authenticate against RHSSO and fetch an acces_token using ocm-cli config refresh_token, this PR is added since offline token deprecation, and to add the new authentication method required.