NO-ISSUE: Fix auto VIPs allocation on local Nutanix flow #2423
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eliorerz: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -66,6 +66,10 @@ def get_ingress_and_api_vips(self): | |||
| "ingress_vips": self._entity_config.ingress_vips, | |||
| } | |||
|
|
|||
| elif self._entity_config.vip_dhcp_allocation is True: | |||
There was a problem hiding this comment.
| elif self._entity_config.vip_dhcp_allocation is True: | |
| else: |
should be enough?
There was a problem hiding this comment.
Nope, we need to differ True, from False from None.
else in this case will include the None case
There was a problem hiding this comment.
can we add some doc at the beginning of the function to describe the 3 cases? I think it would help to understand what we try to achieve
There was a problem hiding this comment.
There was a problem hiding this comment.
I can elaborate more if needed
There was a problem hiding this comment.
yeah, it's just because I find this structure a bit misleading to read:
def f(my_bool):
if my_bool==true:
return
if my_bool==false
return
... more code here because my_bool is none...
There was a problem hiding this comment.
@adriengentil I added a function documentation, LMK if that is OK
There was a problem hiding this comment.
perfect, thanks! Just a typo.
eliorerz
force-pushed
the
NO-ISSUE-Fix-auto-VIPs-allocation-on-Nutanix-flow
branch
from
08f2da3
to
907d6b1
Compare
openshift-ci
bot
added
size/S
|
@eliorerz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| 2) vip_dhcp_allocation is set to True: No need to provide API and Ingress VIP, return None. | ||
| 3) vip_dhcp_allocation is not being set at all and its value is equal to None: In this case, search free IPs | ||
| and set them as VIPs. The behavior is the same as vip_dhcp_allocation = False but getting the IPs first. | ||
| Note that (3) is supposed to happen only locally due to the face that vip_dhcp_allocation is set in CI to some |
There was a problem hiding this comment.
| Note that (3) is supposed to happen only locally due to the face that vip_dhcp_allocation is set in CI to some | |
| Note that (3) is supposed to happen only locally due to the fact that vip_dhcp_allocation is set in CI to some |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
This changes will only take place when running nutanix test locally - because that
vip_dhcp_allocationis always set to false in nutanix CI./cc @adriengentil @danmanor