[release-4.18] change OCL CRD deployment to v1 #2316
Conversation
|
Hello @umohnani8! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
umohnani8
force-pushed
the
4.18
branch
3 times, most recently
from
576421b to
a2bb6bb
Compare
|
/retest |
1 similar comment
|
/retest |
|
/testwith openshift/api/release-4.18/e2e-aws-ovn-techpreview openshift/machine-config-operator#5025 |
|
/testwith openshift/api/release-4.18/e2e-aws-ovn-techpreview openshift/machine-config-operator#5025 |
There was a problem hiding this comment.
We can still use XValidations for the regexes, so please switch those back and use a CEL regex, then we can keep consistent error messages between 4.18 and 4.19
Please also double check my comment about the regexes for resource and namespace, I think if you check 4.19 you'll see that they were not dns1123Subdomain but dns1035Label and dns1123Label respectively
|
/testwith openshift/api/release-4.18/e2e-aws-ovn-techpreview openshift/machine-config-operator#5025 |
|
Thanks @JoelSpeed for the review! I have updated it to use XValidations for the regex with self.matches() |
umohnani8
force-pushed
the
4.18
branch
2 times, most recently
from
ddcf49c to
83742fb
Compare
|
/testwith openshift/api/release-4.18/e2e-aws-ovn-techpreview openshift/machine-config-operator#5025 |
Squashed commit messages:
- MachineOSConfig: set ImageSecretObjectReference to optional
- Add v1 versions of OnClusterBuild APIs
- First step to GA'ing the currently v1alpha1 APIs. Don't add to payload
manifests yet, and the featuregate is retained.
- Temporarily exclude v1 MOSC/MOSB from payload
- Update godoc and validation for MOSC/MOSB
Mostly fixups, with some minor changes to the v1alpha1 API:
- Removed Version and ConfigGeneration from MOSB as they were unused
- Updated relatedobjects list
- Changed all optional,omitempty structs to pointers
- Removed default for ImageBuilderType, but keeping default build arch
to noarch as we don’t foresee changing that.
- Fixed RenderedImagePushspec validators to match description
Additional fixes for MOSC/MOSB
- Update from PodImageBuilder to JobImageBuilder, and add a
MachineOSBuild reference to MachineOSConfig
- Failed and Interrupted will now cause MOSBuild conditions to be
immutable
- Updated Arch enum to be PascalCase
- Updated relatedObject go doc based on suggestion
- Add validation for buildEnd > buildStart
- Removed conditions field from MOSConfig. The build object is
supposed to reflect conditions instead, so this is not needed
at this time
- Use dns1123 format check for all strings that match, and otherwise
switch pattern checks to validation rules where appropriate
- Updated godocs a bit more for formatting
Additional MOSC/MOSB updates
Mostly fixes around validation and godocs. Added some additional test
cases.
Further MOSC/MOSB updates
- Removed BuildOutputs and the CurrentImagePullSecret field
(not really needed at this time, we’d prefer if the user
would put any additional pull secrets into the cluster-wide
object)
- Removed BuildInputs and lifted all fields to spec, removing:
- ReleaseVersion
- BaseOSImagePullSpec
- BaseOSExtensionsImagePullSpec
Which will be populated directly from the MCO instead. We will
consider re-adding those if there is a need for on cluster
pre-builds off new release images in the future.
- Renamed finalImagePushSpec to digestedImagePushSpec
- Switched MachineOSBuilderReference back to an union, and renamed
the job object unionmember to just “job”
- Changed “desiredConfig” to “MachineConfig” for clarity
- Kept ObservedGeneration, but updated the validation, and will
fix on the MCO side
- Removed duplicate arch types, and updated containerfiles to allow at
most 1 per arch (minus noarch)
Read removed NodeDisruptionPolicy tests
These were added for the alpha API originally, but they seem to have
been removed during a refactor of the tests. The current tests are a
duplicate of bootimage tests.
MachineOSBuild: relax CEL for conditions
The builder defaults these conditions to false to start, and the current
CEL prevents that changing.
Use CEL validations
Since the new format library is not avaiable in 4.18,
use similar validations to what we were doing for v1alpha1.
Signed-off-by: Urvashi <[email protected]>
|
/retest |
|
@umohnani8: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/testwith openshift/api/release-4.18/e2e-aws-ovn-techpreview openshift/machine-config-operator#5025 |
Backport the commit to bump the OCL API from v1alpha1 to v1 in 4.18.z in line with the plans to GA this feature in 4.18.z