OCPBUGS-55666: Remove MachineAPIProviderOpenStack feature gate

[mdbooth]

This has not been used since 4.11. It was used by machine-api-operator, but this use was removed in openshift/machine-api-operator#1000.

[openshift-ci]

Hello @mdbooth! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@mdbooth: This pull request references Jira Issue OCPBUGS-55666, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This has not been used since 4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mdbooth]

/jira refresh

[openshift-ci-robot]

@mdbooth: This pull request references Jira Issue OCPBUGS-55666, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/approve
/lgtm
/label acknowledge-critical-fixes-only

Minimal effect to payload, already verified there's nothing relying on this gate, should be inert

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD 7df83cf in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD 7df83cf in total

[openshift-ci]

@mdbooth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp	7df83cf	link	false	/test e2e-gcp
ci/prow/okd-scos-e2e-aws-ovn	7df83cf	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-serial	7df83cf	link	true	/test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview	7df83cf	link	true	/test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD 7df83cf in total

[stephenfin]

/lgtm

I verified than this was unused also.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mdbooth, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[theobarberbany]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 108fecf and 1 for PR HEAD 7df83cf in total