MCO-1663: add explicit opt-out for boot image update in 4.18

[djoshy]

This adds the explicit "None" boot image configuration option in 4.18, which was introduced in 4.19 via #2223. This would allow users to explicitly opt-out of boot image updates in 4.18, prior to upgrading to 4.19.

[openshift-ci-robot]

@djoshy: This pull request references MCO-1663 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.z" version, but no target version was set.

In response to this:

This adds the explicit "None" boot image configuration option in 4.18, which was introduced in 4.19 via #2223.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @djoshy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: djoshy
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@djoshy: This pull request references MCO-1663 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.z" version, but no target version was set.

In response to this:

This adds the explicit "None" boot image configuration option in 4.18, which was introduced in 4.19 via #2223. This would allow users to explicitly opt-out of boot image updates in 4.18, prior to upgrading to 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

To be able to backport, firstly you'll need a bug, and secondly you'll need to mark it as an upgrade blocker (I think).

IIUC, you want to move the minimum 4.18 level to be available to be upgraded to 4.19 to the version of 4.18.z that this will make it into, right?

[openshift-ci]

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial	8fc75e1	link	true	/test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview	8fc75e1	link	true	/test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[djoshy]

So we were not quite sure it rose to the level of an upgrade blocker initially, but https://issues.redhat.com/browse/OCPBUGS-55638 happened and we are planning to add an admin-ack to raise awareness for customers. So yes, I think the best path forward here would be to merge this as an upgrade blocker and add an upgrade edge for this in 4.18.z (admin-ack and the API bump for this folded together). Would that be acceptable?

Edit: Chatted with Trevor, and he mentioned that UpgradeBlocker wasn't necessary to add an upgrade edge if we're able to get this work in before 4.19 GA.

[djoshy]

/close

as per discussion in API office hours, we won't be pursuing this.

[openshift-ci]

@djoshy: Closed this PR.

In response to this:

/close

as per discussion in API office hours, we won't be pursuing this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.