Skip to content

SPLAT-2158: Azure Multi Disk feature gate #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

SPLAT-2158: Azure Multi Disk feature gate #2289

merged 1 commit into from
May 6, 2025
+27 −0

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Apr 22, 2025 •
edited
Loading

Changes

  • New feature gate AzureMultiDisk

Additional PRs

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

Hello @jcpowermac! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 22, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed April 22, 2025 21:09
@jcpowermac jcpowermac changed the title Azure Multi Disk feature gate SPLAT-2158: Azure Multi Disk feature gate Apr 22, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-2158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Changes

  • New feature gate AzureMultiDisk

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed
JoelSpeed reviewed Apr 23, 2025
View reviewed changes
features/features.go Outdated
Comment on lines 40 to 45
reportProblemsToJiraComponent("Management Console").
contactPerson("jhadvig").
productScope(ocpSpecific).
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
enhancementPR("https://github.com/openshift/enhancements/pull/1706").
mustRegister()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't reformat the entire file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goland thought it was helping, pushed without the entire file change

@jcpowermac jcpowermac force-pushed the fg-azure-multi-disk branch from cedbd73 to 242f496 Compare April 23, 2025 11:28
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 23, 2025
JoelSpeed
JoelSpeed reviewed Apr 23, 2025
View reviewed changes
features/features.go Outdated
Comment on lines 822 to 828
FeatureGateAzureMultiDisk = newFeatureGate("AzureMultiDisk").
reportProblemsToJiraComponent("splat").
contactPerson("jcpowermac").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1779").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I be a pain and ask you to match the indentation of the file as it is? Else someone else will swap this back later

@jcpowermac
Add Azure Multi Disk feature gate
b89a168 
This commit adds a feature gate for azure multi disk
@jcpowermac jcpowermac force-pushed the fg-azure-multi-disk branch from 242f496 to b89a168 Compare April 23, 2025 17:54
@JoelSpeed
Copy link
Contributor

/lgtm

/hold

Please don't merge this until after branching has completed

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
@jcpowermac
Copy link
Contributor Author

Branching is complete

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD b89a168 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD b89a168 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD b89a168 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2025

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 108fecf into openshift:master May 6, 2025
24 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202505061310.p0.g108fecf.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcpowermac @openshift-ci-robot @JoelSpeed @openshift-bot