Add vscode integration for golangci-kal

.golangci.yaml

@@ -9,3 +9,8 @@ linters:
   disable-all: true
   enable:
     - kal
+issues:
+  # We have a lot of existing issues.
+  # Want to make sure that those adding new fields have an
+  # opportunity to fix them when running the linter locally.
+  max-issues-per-linter: 1000

.vscode/settings.json

@@ -0,0 +1,6 @@
+{
+    "go.lintTool": "golangci-lint",
+    "go.alternateTools": {
+        "golangci-lint": "${workspaceFolder}/hack/golangci-lint.sh",
+    }
+}

Makefile

@@ -39,6 +39,13 @@ update-codegen-crds: update-scripts
 #
 #####################
 
+# When not otherwise set, diff/lint against the local master branch
+PULL_BASE_SHA ?= master
+
+.PHONY: lint
+lint:
+	hack/golangci-lint.sh run --new-from-rev=${PULL_BASE_SHA}
+
 .PHONY: verify-scripts
 verify-scripts:
 	bash -x hack/verify-deepcopy.sh
@@ -56,7 +63,7 @@ verify-scripts:
 	hack/verify-promoted-features-pass-tests.sh
 
 .PHONY: verify
-verify: verify-scripts verify-crd-schema verify-codegen-crds
+verify: verify-scripts lint verify-crd-schema verify-codegen-crds
 
 .PHONY: verify-codegen-crds
 verify-codegen-crds:

hack/golangci-lint.sh

@@ -0,0 +1,18 @@
+#!/bin/bash
+
+source "$(dirname "${BASH_SOURCE}")/lib/init.sh"
+
+# Build codegen-crds when it's not present and not overriden for a specific file.
+if [ -z "${GOLANGCI_LINT:-}" ];then
+  ${TOOLS_MAKE} golangci-kal
+  GOLANGCI_LINT="${TOOLS_OUTPUT}/golangci-kal"
+fi
+
+# In CI, HOME is set to / and is not writable.
+# Make sure golangci-lint can create its cache.
+HOME=${HOME:-"/tmp"}
+if [[ ${HOME} == "/" ]]; then
+  HOME="/tmp"
+fi
+
+"${GOLANGCI_LINT}" $@