OAPE-194: UPSTREAM: <carry>: Add downstream README file #46

arkadeepsen · 2025-05-29T15:20:39Z

Description of the change:

This PR adds a README file for the downstream operations.

Motivation for the change:

The downstream operations are not well documented. This PR tries to address that by adding the README file.

openshift-ci-robot · 2025-05-29T15:20:44Z

@arkadeepsen: This pull request references OAPE-194 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Description of the change:

This PR adds a README file for the downstream operations.

Motivation for the change:

The downstream operations are not well documented. This PR tries to address that by adding the README file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

chiragkyal

Mostly nits. Thanks for the documentation.

chiragkyal · 2025-05-30T13:43:18Z

openshift/README.md

+
+The downstream artifacts are as follows:
+
+* openshift - contains files for building downstream ansible operator base image


nit: Please add quotes for folder/file names...Same for all the next bullets.

Suggested change

* openshift - contains files for building downstream ansible operator base image

* `openshift` - contains files for building downstream ansible operator base image

chiragkyal · 2025-05-30T13:44:18Z

openshift/README.md

+The downstream artifacts are as follows:
+
+* openshift - contains files for building downstream ansible operator base image
+* openshift/ci - contains the CI related build files


nit: Periods at the end of the sentences.

Suggested change

* openshift/ci - contains the CI related build files

* openshift/ci - contains the CI related build files.

chiragkyal · 2025-05-30T13:46:01Z

openshift/README.md

+* openshift - contains files for building downstream ansible operator base image
+* openshift/ci - contains the CI related build files
+* openshift/hack - contains the scripts for updating downstream files
+* openshift/release/ansible - ansible operator release files


openshift/release/ansible mostly contains the collections I think

chiragkyal · 2025-05-30T13:48:26Z

openshift/README.md

+openshift       https://github.com/openshift/ansible-operator-plugins.git (fetch)
+openshift       no_push (push)
+origin  [email protected]:arkadeepsen/ansible-operator-plugins.git (fetch)
+origin  [email protected]:arkadeepsen/ansible-operator-plugins.git (push)


Suggested change

origin [email protected]:arkadeepsen/ansible-operator-plugins.git (push)

origin [email protected]:username/ansible-operator-plugins.git (push)

chiragkyal · 2025-05-30T13:50:22Z

openshift/README.md

+```
+## New release to main
+
+Once the `upstream` has been verified. You can now sync the upstream release tag


Suggested change

Once the `upstream` has been verified. You can now sync the upstream release tag

Once the `upstream` has been verified, you can now sync the upstream release tag

chiragkyal · 2025-06-03T08:34:39Z

openshift/README.md

+...
+```
+
+After the commits are listed, the vendor directory is updata:


Suggested change

After the commits are listed, the vendor directory is updata:

After the commits are listed, the vendor directory is updated

chiragkyal · 2025-06-03T08:36:28Z

openshift/README.md

+Here is the output of running the above script.
+
+```
+$ ./openshift/hack/rebase_upstream.sh v1.37.2 release-4.17


Please hide the output by default.

chiragkyal · 2025-06-03T08:37:29Z

openshift/README.md

+and the requirements files in the `./openshift` directory are properly generated. This will require manual intervention and
+inspection.
+
+Once these directories have been verified, create a release PR downstream:


Suggested change

Once these directories have been verified, create a release PR downstream:

Once these directories have been verified, create a rebase PR downstream:

chiragkyal · 2025-06-03T08:39:45Z

openshift/README.md

+  can be used. This script runs the upstream
+  [`pip_find_builddeps.py`](https://raw.githubusercontent.com/containerbuildsystem/cachito/master/bin/pip_find_builddeps.py)
+  script repeatedly for each python package to find the corresponding build dependencies. It needs the requirements.txt file
+  generated from the upstream Pipfile and Pipfile.lock files.


Suggested change

generated from the upstream Pipfile and Pipfile.lock files.

generated from the upstream `images/Pipfile` and `images/Pipfile.lock` files.

chiragkyal · 2025-06-03T08:43:28Z

openshift/README.md

+```
+git push origin v1.38.0-rebase-main
+```
+


We need to add another step (with a highlight maybe) here to get a test built out by the ART team before merging the PR.

arkadeepsen · 2025-06-06T13:08:02Z

/skip

chiragkyal

Thanks for the changes.
/lgtm

chiragkyal · 2025-06-06T18:33:25Z

openshift/README.md

+information about the output see the [breakdown of rebase_upstream.sh
+output](#breakdown-of-rebase_upstreamsh-output) section below.
+
+At this point, you _must_ verify if everything looks. Ensure that the `./openshift/release/ansible/ansible_collections` directory


Suggested change

At this point, you _must_ verify if everything looks. Ensure that the `./openshift/release/ansible/ansible_collections` directory

At this point, you _must_ verify if everything looks okay. Ensure that the `./openshift/release/ansible/ansible_collections` directory

chiragkyal · 2025-06-09T07:06:55Z

/lgtm
/approve
/retest

openshift-ci · 2025-06-09T07:07:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen, chiragkyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [arkadeepsen,chiragkyal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chiragkyal · 2025-06-09T07:07:35Z

/label qe-approved
no impact

openshift-ci-robot · 2025-06-09T07:07:39Z

@arkadeepsen: This pull request references OAPE-194 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Description of the change:

This PR adds a README file for the downstream operations.

Motivation for the change:

The downstream operations are not well documented. This PR tries to address that by adding the README file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-06-09T07:17:49Z

/retest-required

Remaining retests: 0 against base HEAD 88cac2a and 2 for PR HEAD 9f87a5e in total

arkadeepsen · 2025-06-09T08:11:35Z

/retest

openshift-ci-robot · 2025-06-09T09:35:06Z

/retest-required

Remaining retests: 0 against base HEAD 88cac2a and 2 for PR HEAD 9f87a5e in total

arkadeepsen · 2025-06-09T13:42:45Z

/retest

openshift-ci-robot · 2025-06-09T15:14:17Z

/retest-required

Remaining retests: 0 against base HEAD 88cac2a and 2 for PR HEAD 9f87a5e in total

chiragkyal · 2025-06-09T15:25:11Z

/test all

I want to see if images is passing or not. Looks like we're hitting this issue.

arkadeepsen · 2025-06-09T15:31:13Z

/test all

I want to see if images is passing or not. Looks like we're hitting this issue.

That should not cause an issue in the CI. The issue is for building the image in the OSBS environment.

arkadeepsen · 2025-06-10T03:04:16Z

/retest

openshift-ci · 2025-06-10T05:34:40Z

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2025-06-10T09:43:09Z

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-ansible-operator
This PR has been included in build openshift-enterprise-ansible-operator-container-v4.20.0-202506100817.p0.g271ad55.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2025

openshift-ci bot requested review from chiragkyal and varshaprasad96 May 29, 2025 15:21

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025

arkadeepsen mentioned this pull request May 29, 2025

OAPE-191: UPSTREAM: <carry>: Add rebase script #45

Merged

chiragkyal reviewed Jun 3, 2025

View reviewed changes

arkadeepsen force-pushed the downstream-readme branch from cca427c to 1b611ff Compare June 6, 2025 13:06

arkadeepsen force-pushed the downstream-readme branch from 1b611ff to cd42de8 Compare June 6, 2025 13:55

chiragkyal reviewed Jun 6, 2025

View reviewed changes

openshift-ci bot assigned chiragkyal Jun 6, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2025

UPSTREAM: <carry>: Add downstream README file

9f87a5e

arkadeepsen force-pushed the downstream-readme branch from cd42de8 to 9f87a5e Compare June 9, 2025 06:21

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 9, 2025

openshift-merge-bot bot merged commit 271ad55 into openshift:main Jun 10, 2025
7 checks passed


		The downstream artifacts are as follows:

		* openshift - contains files for building downstream ansible operator base image

	* openshift - contains files for building downstream ansible operator base image
	* `openshift` - contains files for building downstream ansible operator base image

	* openshift/ci - contains the CI related build files
	* openshift/ci - contains the CI related build files.

	origin [email protected]:arkadeepsen/ansible-operator-plugins.git (push)
	origin [email protected]:username/ansible-operator-plugins.git (push)

	Once the `upstream` has been verified. You can now sync the upstream release tag
	Once the `upstream` has been verified, you can now sync the upstream release tag

	After the commits are listed, the vendor directory is updata:
	After the commits are listed, the vendor directory is updated

	Once these directories have been verified, create a release PR downstream:
	Once these directories have been verified, create a rebase PR downstream:

	generated from the upstream Pipfile and Pipfile.lock files.
	generated from the upstream `images/Pipfile` and `images/Pipfile.lock` files.

	At this point, you _must_ verify if everything looks. Ensure that the `./openshift/release/ansible/ansible_collections` directory
	At this point, you _must_ verify if everything looks okay. Ensure that the `./openshift/release/ansible/ansible_collections` directory

OAPE-194: UPSTREAM: <carry>: Add downstream README file #46

OAPE-194: UPSTREAM: <carry>: Add downstream README file #46

Uh oh!

Conversation

arkadeepsen commented May 29, 2025

Uh oh!

openshift-ci-robot commented May 29, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chiragkyal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkadeepsen commented Jun 6, 2025

Uh oh!

chiragkyal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chiragkyal commented Jun 9, 2025

Uh oh!

openshift-ci bot commented Jun 9, 2025

Uh oh!

chiragkyal commented Jun 9, 2025

Uh oh!

openshift-ci-robot commented Jun 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 9, 2025

Uh oh!

arkadeepsen commented Jun 9, 2025

Uh oh!

openshift-ci-robot commented Jun 9, 2025

Uh oh!

arkadeepsen commented Jun 9, 2025

Uh oh!

openshift-ci-robot commented Jun 9, 2025

Uh oh!

chiragkyal commented Jun 9, 2025

Uh oh!

arkadeepsen commented Jun 9, 2025

Uh oh!

arkadeepsen commented Jun 10, 2025

Uh oh!

openshift-ci bot commented Jun 10, 2025

Uh oh!

Uh oh!

openshift-bot commented Jun 10, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented May 29, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jun 9, 2025 •

edited by openshift-ci bot

Loading