-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add touchstone to nodevertical/mastervertical for getting the prometheus data aggregates #141
Open
amitsagtani97
wants to merge
35
commits into
openshift-scale:master
Choose a base branch
from
amitsagtani97:add_touchstone_work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Add touchstone to nodevertical/mastervertical for getting the prometheus data aggregates #141
amitsagtani97
wants to merge
35
commits into
openshift-scale:master
from
amitsagtani97:add_touchstone_work
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is highly inspired from openshift-scale#131. It enables the users to collect pprof data through conprof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collects the prometheus data aggregates (sum, max, min, deviation, percentile) and stores them using touchstone(pr 18)
To get a good idea of resource utilization during the tests which can be further indexed to elasticsearch and to enable run to run comparison.
A sample output -
[{'url': 'https://prometheus-k8s-openshift-monitoring.apps.amitsagtani.perf-testing.devcluster.openshift.com', 'query': 'sum(container_memory_rss{namespace=~"openshift-kube-apiserver",name!="",container=~"kube-apiserver.*"}) by (container)', 'start_time': 1593002625, 'end_time': 1593002626, 'sum': 4799680512.0, 'max': 4644671488.0, 'min': 57843712.0, 'deviation': 2153043005.6000533, 'average': 1599893504.0, 'percentile_95.0': 4189920870.3999996}]
this represents the aggregates for the query -
sum(container_memory_rss{namespace=~"openshift-kube-apiserver",name!="",container=~"kube-apiserver.*"}) by (container)
during the test run time.