WIP: Refactor OpenAI Plugin #57
Draft
+201
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmonson
force-pushed
the
fix/openai_refactor
branch
2 times, most recently
from
8ed9787
to
3fa9e40
Compare
sjmonson
force-pushed
the
fix/openai_refactor
branch
from
3fa9e40
to
0035799
Compare
sjmonson
force-pushed
the
fix/openai_refactor
branch
from
728fbfa
to
39f0864
Compare
sjmonson
force-pushed
the
fix/openai_refactor
branch
from
bc6c970
to
74380e2
Compare
This avoids a circular dependency
This reverts commit 3e5ff9b. We can't do this without changing how the plugins handle request_func since @abstractmethods must be implemented not assigned.
sjmonson
force-pushed
the
fix/openai_refactor
branch
from
8ffa172
to
a924bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the OpenAI API plugin to make it more readable and improve error handling.