fix: handle optional usage field in OpenAI API #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrip
changed the title
npalaska
reviewed
Jun 10, 2024
plugins/openai_plugin.py
Outdated
| # total tokens before the timeout will be equal to the total tokens in the response. | ||
| if not result.output_tokens_before_timeout: | ||
| result.output_tokens_before_timeout = result.output_tokens | ||
| result.stop_reason = message["choices"][0]["finish_reason"] |
There was a problem hiding this comment.
You might wanna do the same (.get) for choices
dagrayvid
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage field that is returned in the
completionobject is optional and will cause errors in runtimes that do not include it. In particular I noticed this in the runtime that instructlab uses.OpenAI API docs for the completion object