Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable streaming for openai_plugin /v1/completions #45

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dagrayvid
Copy link
Collaborator

No description provided.

This PR fixes a bug where streaming: True was not set when using
the /v1/completions endpoint with the openai plugin.
@dagrayvid dagrayvid changed the title Minor fix for openai_plugin streaming with v1/completions fix: re-enable streaming for openai_plugin /v1/completions Jun 5, 2024
Copy link
Collaborator

@npalaska npalaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dagrayvid dagrayvid merged commit 3d76871 into openshift-psap:main Jun 5, 2024
4 checks passed
@ccamacho
Copy link
Contributor

ccamacho commented Jun 5, 2024

LGTM but too late to +2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants