ckcp: Optimize resource requests and limits #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note - with this configuration update, ckcp can be deployed on a minimal AWS IPI-installed cluster (3 control plane nodes, 3 m6i.large worker nodes with 2 CPU, ~8Gi RAM) |
fgiloux
reviewed
Aug 5, 2022
ckcp/openshift/base/deployment.yaml
Outdated
| @@ -38,10 +38,11 @@ spec: | |||
| value: ckcp-ckcp.apps.domain.org | |||
| resources: | |||
| limits: | |||
| cpu: 1000m | |||
There was a problem hiding this comment.
What is the purpose of the cpu limit?
Limit does not play any role in scheduling or resource reservation.
It could protect against a bad behavior of kcp but if kcp is not responding there is nothing left to protect.
There was a problem hiding this comment.
I'll remove this. Since CPU is compressible, limits only throttle the process. This doesn't really matter for development.
kcp-in-container (ckcp) currently has CPU and memory requests that make it difficult to schedule on a standard IPI cluster. In testing, the following behavior was observed: - Initial memory usage hits 177Mi, is never lower. - kcp memory increases to ~500Mi once syncer is deployed. - CPU usage rarely exceeds 0.1 CPU per minute. 100m CPU request is typical for a system workload. Signed-off-by: Adam Kaplan <[email protected]>
Roming22
pushed a commit
that referenced
this pull request
Dec 19, 2022
from https://github.com/redhat-appstudio/build-definitions 93dac682ee16a08634d593b836758e1d4fa8d967 Co-authored-by: Build deployer <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kcp-in-container (ckcp) currently has CPU and memory requests that make
it difficult to schedule on a standard IPI cluster. In testing, the
following behavior was observed:
typical for a system workload.
Partially addresses #118