Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNI] cmd: dump version on startup #225

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ffromani
Copy link
Member

@ffromani ffromani commented Sep 2, 2024

log the component version first time as startup to make the troubleshooting (a bit) easier.

Copy link

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
log the component version first time as startup to
make the troubleshooting (a bit) easier.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani changed the title cmd: dump version on startup [KNI] cmd: dump version on startup Sep 2, 2024
@ffromani ffromani added the cherry-pick-candidate Propose a cherry-pick to stable branches label Sep 2, 2024
@ffromani
Copy link
Member Author

ffromani commented Sep 2, 2024

/cc @shajmakh

@openshift-ci openshift-ci bot requested a review from shajmakh September 2, 2024 10:41
@ffromani
Copy link
Member Author

ffromani commented Sep 2, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shajmakh
Copy link
Member

shajmakh commented Sep 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 69c872c into master Sep 3, 2024
7 checks passed
@openshift-cherrypick-robot

@ffromani: new pull request created: #226

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-candidate Propose a cherry-pick to stable branches lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants