Add DELETE support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note that this shares a commit with #66. That should be merged before this, and then this should be rebased. |
This patch adds support for the `DELETE` HTTP method. The adapter will now
accept the `DELETE` method and call the `Delete` method defined in the
`DeleteHandler` interface. For example, a simple implementation that
stores the object in a map in memory could look like this:
```go
func (h *MyHandler) Delete(ctx context.Context, request *AddRequest) (respone *AddResponse, err error) {
h.storeLock.Lock()
defer h.storeLock.Unlock()
delete(h.storeMap, request.Variables[0])
return
}
```
Signed-off-by: Juan Hernandez <[email protected]>
jhernand
force-pushed
the
add_delete_support_to_http_handler
branch
from
d9002bb
to
b6f66f1
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DELETE support
This patch adds support for the
DELETEHTTP method. The adapter will now accept theDELETEmethod and call theDeletemethod defined in theDeleteHandlerinterface. For example, a simple implementation that stores the object in a map in memory could look like this: