Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update dev env instructions #45

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

danielerez
Copy link
Collaborator

Updated 'Create parameters yaml' section:

  • s/pull_secret/pullsecret
  • Added a note about 'pool' and 'pullsecret' attributes.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 25, 2023
Copy link

openshift-ci bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit bd46283 into openshift-kni:main Dec 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants