Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16112: Add OpenAPI handler #42

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jhernand
Copy link
Collaborator

This patch adds a new /o2ims-infrastructureInventory/v1/openapi endpoint that returns the OpenAPI specification of the service.

Currently this specification only covers the metadata and the deployment manager endpoints. Other endpoints will be added later.

Related: https://issues.redhat.com/browse/MGMT-16112

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 15, 2023

@jhernand: This pull request references MGMT-16112 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This patch adds a new /o2ims-infrastructureInventory/v1/openapi endpoint that returns the OpenAPI specification of the service.

Currently this specification only covers the metadata and the deployment manager endpoints. Other endpoints will be added later.

Related: https://issues.redhat.com/browse/MGMT-16112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhernand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This patch adds a new `/o2ims-infrastructureInventory/v1/openapi`
endpoint that returns the OpenAPI specification of the service.

Currently this specification only covers the metadata and the deployment
manager endpoints. Other endpoints will be added later.

Related: https://issues.redhat.com/browse/MGMT-16112
Signed-off-by: Juan Hernandez <[email protected]>
@danielerez
Copy link
Collaborator

/lgtm
Note: just wonder whether the spec can be generated from code on every change.
Maybe using huma: https://github.com/danielgtaylor/huma/blob/8f089757a73fa97636099306a6549745e1f1bb8f/docs/docs/features/openapi-generation.md?plain=1#L9

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2023
@jhernand jhernand merged commit 9df83e2 into openshift-kni:main Dec 19, 2023
6 of 7 checks passed
@jhernand jhernand deleted the add_openapi_endpoint branch December 19, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants