Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16243: set 'location' property on ResourcePool #36

Merged

Conversation

danielerez
Copy link
Collaborator

Set 'location' in ResourcePool object according to a 'region' label in the cluster (if exists).

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 5, 2023

@danielerez: This pull request references MGMT-16243 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Set 'location' in ResourcePool object according to a 'region' label in the cluster (if exists).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Set 'location' in ResourcePool object according to
a 'region' label in the cluster (if exists).
@jhernand
Copy link
Collaborator

jhernand commented Dec 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@jhernand
Copy link
Collaborator

jhernand commented Dec 6, 2023

/approve

Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 9306940 into openshift-kni:main Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants