Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-16107: added resourceTypes endpoints #32

Merged
merged 1 commit into from
Nov 28, 2023
Merged

MGMT-16107: added resourceTypes endpoints #32

merged 1 commit into from
Nov 28, 2023

Conversation

danielerez
Copy link
Collaborator

  • Added the following endpoints:
    • /resourceTypes
    • /resourceTypes/{resourceTypeID}
  • Populated resoruceTypeID property on Resource object.
    • Note: resourceTypeID is currently generated using properties from Resource objects. We'll probably need to reconsider it later on.

@danielerez
MGMT-16107: added resourceTypes endpoints
aeb3edc 
* Added the following endpoints:
  * /resourceTypes
  * /resourceTypes/{resourceTypeID}
* Populated resoruceTypeID property on Resource object.
  * Note: resourceTypeID is currently generated using
          properties from Resource objects.
          We'll probably need to reconsider it later on.
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot
Loading

@danielerez: This pull request references MGMT-16107 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

  • Added the following endpoints:
  • /resourceTypes
  • /resourceTypes/{resourceTypeID}
  • Populated resoruceTypeID property on Resource object.
  • Note: resourceTypeID is currently generated using properties from Resource objects. We'll probably need to reconsider it later on.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhernand
jhernand approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@jhernand jhernand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @danielerez.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit f22b1c1 into openshift-kni:main Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhernand jhernand jhernand approved these changes

@irinamihai irinamihai Awaiting requested review from irinamihai

Assignees

@jhernand jhernand

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielerez @openshift-ci-robot @jhernand