Add --api-listener-... flags to resource server
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the `--api-listener-...` flags to the resource server: ``` $ ./oran-o2ims start resource-server \ --api-listener-address=localhost:8002 \ ``` This is intended for use in the reverse proxy configuration started with `proxy.sh`, as it requires different ports for different services. Note that a side effect of this is that the default port is now `8000` instead of `8080`. Related: https://issues.redhat.com/browse/MGMT-16113 Signed-off-by: Juan Hernandez <[email protected]>
|
FYI: @danielerez |
danielerez
reviewed
Nov 14, 2023
| --log-field="pid=%p" \ | ||
| --api-listener-address="127.0.0.1:8002" \ | ||
| --cloud-id="123" \ | ||
| --backend-url="${BACKEND_URL}" \ |
There was a problem hiding this comment.
Not related to this PR, just wonder if we should support multiple backend URLs?
I.e. should we open a ticket for supporting something like RESOURCE_BACKEND_URL, in case the search api is routed using a different domain? Or is it an unlikely scenario...
There was a problem hiding this comment.
Yes, you are right, we should support multiple backend URLs, one for each kind of backend. Please open that ticket.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the
--api-listener-...flags to the resource server:This is intended for use in the reverse proxy configuration started with
proxy.sh, as it requires different ports for different services.Note that a side effect of this is that the default port is now
8000instead of8080.Related: https://issues.redhat.com/browse/MGMT-16113