[release-4.14][manual] consume support for scheduler plugin informerMode from upstream #846
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test ci-e2e is this a flake with a terrible timing? |
|
ok, not a flake. Investigating. |
|
/hold checking the scheduler side. Probably unnecessary bordering harmful |
openshift-ci
bot
added
the
do-not-merge/hold
|
we don't want this change now: openshift-kni/scheduler-plugins#165 |
|
/reopen |
|
@ffromani: Failed to re-open PR: state cannot be changed. The informer-support-4.14 branch has been deleted. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@ffromani: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
extract helper to be used later to fine-tune the scheduler behavior. Parial cherry-pick from #801 Signed-off-by: Francesco Romani <[email protected]>
Previously, the NUMA-aware scheduler plugin had d/s-specific code to enable the separate informer, which was in turn needed to get the full pod list vs the filtered pod list the scheduler framework provides. Thus, we had d/s specific enablement in the operator. Since commit 93c518b the upstream added support for the separate informer, consumed by the KNI scheduler since commit 780ea84. Removed the d/s specific enablement and set the proper configuration value. release-4.15 notes: reordered commits, make it indpendent from PR #801
ffromani
force-pushed
the
informer-support-4.14
branch
from
419f5dd
to
d324239
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
the failure is expected because openshift-kni/scheduler-plugins#223 merged but the lane restarted before automation pushed an updated image |
|
/retest |
|
@ffromani: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
re-closing with better explanation of the reason. Would depend on the config AP v1beta3. the branch 4.14 was using v1beta2, and we can't update mid-Z-stream, especially so late in the stream. xref: openshift-kni/scheduler-plugins#224 |
Previously, the NUMA-aware scheduler plugin had d/s-specific code to enable the separate informer, which was in turn needed to get the full pod list vs the filtered pod list the scheduler framework provides. Thus, we had d/s specific enablement in the operator. Since commit kubernetes-sigs/scheduler-plugins#599 the upstream added support for the separate informer, consumed by the KNI scheduler since commit openshift-kni/scheduler-plugins#161. Remove the d/s specific enablement and set the proper configuration value.
We expect no changes from UX perspective. This is an internal change only.
backport notice: add targeted fixes to make this PR independent from (the backport of) #801
backport notice: manual backport of #845