cnf network: fix-dpdk-test-case #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkopels
force-pushed
the
fix-dpdk-test-cases
branch
3 times, most recently
from
ed0611e
to
fa0bc7e
Compare
|
/lgtm |
evgenLevin
reviewed
Jul 4, 2024
| testCmdNet2 = []string{"bash", "-c", "sleep 5; testcmd -interface net2 -protocol tcp " + | ||
| "-port 4444 -listen"} | ||
| testCmdNet2Net3 = []string{"bash", "-c", "sleep 5; testcmd -interface net2 -protocol tcp " + | ||
| "-port 4444 -listen & testcmd -interface net3 -protocol tcp -port 4444 -listen"} | ||
| testCmdBond0 = []string{"bash", "-c", "sleep 5; testcmd -interface bond0.100 -protocol tcp " + | ||
| "-port 4444 -listen"} | ||
| tcpDumpNet1CMD = []string{"bash", "-c", "tcpdump -i net1 -e > /tmp/tcpdump"} | ||
| tcpDumpNet1CMD = []string{"bash", "-c", "tcpdump -i net1 -e > /tmp/tcpdump"} | ||
|
|
| @@ -712,6 +706,19 @@ func defineAndCreateSrIovNetworkWithQinQ(srIovNetwork, resName, vlanProtocol str | |||
| "Fail to pull NetworkAttachmentDefinition") | |||
| } | |||
|
|
|||
| func defineAndCreateSrIovNetworkClientDPDK(srIovNetwork, resName string) { | |||
There was a problem hiding this comment.
Changed to srIovNetworkName
| func defineAndCreateSrIovNetworkClientDPDK(srIovNetwork, resName string) { | ||
| srIovNetworkObject, err := sriov.NewNetworkBuilder( | ||
| APIClient, srIovNetwork, NetConfig.SriovOperatorNamespace, tsparams.TestNamespaceName, resName).Create() | ||
| Expect(err).ToNot(HaveOccurred(), fmt.Sprintf("Failed to create sriov network %s", err)) |
There was a problem hiding this comment.
remove fmt.Sprintf and err
| @@ -814,6 +821,7 @@ func readAndValidateTCPDump(clientPod *pod.Builder, testCmd []string, pattern st | |||
| By("Start to capture traffic on the promiscuous client") | |||
|
|
|||
| output, err := clientPod.ExecCommand(testCmd) | |||
| fmt.Println(output.String()) | |||
| @@ -956,16 +966,15 @@ func defineAndCreateClientDPDKPod( | |||
| Expect(err).ToNot(HaveOccurred(), "Fail to define client dpdk container") | |||
|
|
|||
| dpdkPod, err := pod.NewBuilder(APIClient, podName, tsparams.TestNamespaceName, | |||
| NetConfig.DpdkTestContainer).WithSecondaryNetwork(serverPodNetConfig). | |||
| NetConfig.DpdkTestContainer).WithSecondaryNetwork(serverPodNetConfig).WithPrivilegedFlag(). | |||
There was a problem hiding this comment.
Why do you need WithPrivilegedFlag() if you created corev1.SecurityContext?
| vlan, err := strconv.Atoi(NetConfig.VLAN) | ||
| Expect(err).ToNot(HaveOccurred(), "Failed to convert VLAN value") | ||
| testOutPutString = fmt.Sprintf("(ethertype 802\\.1Q \\(0x8100\\)).*?(vlan %d)", vlan) | ||
| fmt.Println(testOutPutString) |
gkopels
force-pushed
the
fix-dpdk-test-cases
branch
from
fa0bc7e
to
24f7e2c
Compare
gkopels
force-pushed
the
fix-dpdk-test-cases
branch
from
24f7e2c
to
9c583e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.