-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating a unit test using mocking for the generate SS function #20
Conversation
update the function: remove unused vars and update the debug object to use the mock functions on test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be okay as far as unit tests go. The only functional changes just move parameters from struct to interface which is fine.
Co-authored-by: Brandon Palm <[email protected]>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
update the function: remove unused vars
and update the debug object to use the mock functions on test