Fix docgen shuffling order of markdown everytime #395
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @oribon. Thanks for your PR. I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cnf-tests/docgen/cmd/generate.go
Outdated
| @@ -124,10 +124,11 @@ func descriptionsToList(descriptions map[string]string, matcher func(string) boo | |||
| if !matcher(n) { | |||
| continue | |||
| } | |||
| n = sanitizeName(n) | |||
There was a problem hiding this comment.
Can you use a different name here?
Something like sanitizedName := sanitazeName(n)
Reusing the variable may cause a bit of confusion
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol, oribon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@oribon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
1 similar comment
|
/retest |
problem was caused because the sort happened before cleaning the string
#373