OCPBUGS-39149: ztp: empty file in sitegen kustomize plugin

[abraham2512]

This MR includes a check to safely ignore empty file in testUserExtraManifest consumed by siteconfig-generator-kustomize-plugin, which caused addZTPAnnotationToManifest to panic.

This is an additional MR for addressing a missed scenario from
#2022

[openshift-ci-robot]

@abraham2512: This pull request references Jira Issue OCPBUGS-39149, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This MR includes a check to safely ignore empty file in testUserExtraManifest consumed by siteconfig-generator-kustomize-plugin, which caused addZTPAnnotationToManifest to panic.

This will avoid addZTPAnnotationToManifest for empty values and will ignore file from dataMap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sabbir-47]

/jira refresh

[openshift-ci-robot]

@sabbir-47: This pull request references Jira Issue OCPBUGS-39149, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sabbir-47]

/jira refresh

[openshift-ci-robot]

@sabbir-47: This pull request references Jira Issue OCPBUGS-39149, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sabbir-47]

/lgtm

[sabbir-47]

/jira refresh

[openshift-ci-robot]

@sabbir-47: This pull request references Jira Issue OCPBUGS-39149, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sabbir-47]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abraham2512, sabbir-47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ztp/OWNERS [sabbir-47]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@abraham2512: Jira Issue OCPBUGS-39149: All pull requests linked via external trackers have merged:

• openshift-kni/cnf-features-deploy#2022
• openshift-kni/cnf-features-deploy#2052

Jira Issue OCPBUGS-39149 has been moved to the MODIFIED state.

In response to this:

This MR includes a check to safely ignore empty file in testUserExtraManifest consumed by siteconfig-generator-kustomize-plugin, which caused addZTPAnnotationToManifest to panic.

This is an additional MR for addressing a missed scenario from
#2022

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sabbir-47]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@sabbir-47: new pull request created: #2101

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.