Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Run make generated-files #2963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Generated by running make generated-files

@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 2 times, most recently from 88dd10c to 9a17227 Compare October 21, 2024 09:43
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from 9a17227 to 7072bec Compare October 21, 2024 09:45
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 7 times, most recently from 64d7be9 to 789bd32 Compare October 25, 2024 06:43
@pierDipi
Copy link
Member

@creydr

source: "registry.redhat.io/openshift-serverless-1/kn-backstage-plugins-eventmesh-rhel8"
source: "registry.redhat.io/openshift-serverless-1/kn-backstage-plugins-eventmesh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
Let me check on this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mabye registry.ci.openshift.org/knative/serverless-index:main has still the old image references:

Add mirror image to 'olm-catalog/serverless-operator-index/image_content_source_policy.yaml' - registry.redhat.io/openshift-serverless-1/kn-backstage-plugins-eventmesh = quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-backstage-plugins-eventmesh
Add mirror image to 'olm-catalog/serverless-operator-index/image_content_source_policy.yaml' - registry.redhat.io/openshift-serverless-1/kn-ekb-dispatcher = quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-ekb-dispatcher

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we even use registry.ci.openshift.org/knative/serverless-index:main at this point here ? We could use quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135-fbc-417/serverless-index-135-fbc-417:1.35.0

Copy link
Member

@pierDipi pierDipi Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only reason that I've used that one is that there was a variable already available to reference the version specific index, to get the exact index through quay we would need to move the logic to map URLs from images.bash to (maybe) vars

@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 2 times, most recently from 191a75f to 821440a Compare October 25, 2024 07:04
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 3 times, most recently from 6900790 to d8967e0 Compare October 25, 2024 11:15
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from d8967e0 to 543bb56 Compare October 26, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants