-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Run make generated-files #2963
base: main
Are you sure you want to change the base?
Conversation
88dd10c
to
9a17227
Compare
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: github-actions[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9a17227
to
7072bec
Compare
64d7be9
to
789bd32
Compare
source: "registry.redhat.io/openshift-serverless-1/kn-backstage-plugins-eventmesh-rhel8" | ||
source: "registry.redhat.io/openshift-serverless-1/kn-backstage-plugins-eventmesh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Let me check on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mabye registry.ci.openshift.org/knative/serverless-index:main
has still the old image references:
Add mirror image to 'olm-catalog/serverless-operator-index/image_content_source_policy.yaml' - registry.redhat.io/openshift-serverless-1/kn-backstage-plugins-eventmesh = quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-backstage-plugins-eventmesh
Add mirror image to 'olm-catalog/serverless-operator-index/image_content_source_policy.yaml' - registry.redhat.io/openshift-serverless-1/kn-ekb-dispatcher = quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-ekb-dispatcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we even use registry.ci.openshift.org/knative/serverless-index:main
at this point here ? We could use quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135-fbc-417/serverless-index-135-fbc-417:1.35.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only reason that I've used that one is that there was a variable already available to reference the version specific index, to get the exact index through quay we would need to move the logic to map URLs from images.bash to (maybe) vars
191a75f
to
821440a
Compare
6900790
to
d8967e0
Compare
d8967e0
to
543bb56
Compare
Generated by running
make generated-files