Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Serving manifests to 1.14 #2656

Merged
merged 2 commits into from
May 14, 2024
Merged

Bump Serving manifests to 1.14 #2656

merged 2 commits into from
May 14, 2024
+8,806 −4,985

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 13, 2024 •
edited
Loading

Fixes JIRA #

Proposed Changes

wget --no-check-certificate https://raw.githubusercontent.com/openshift-knative/eventing-kafka-broker/release-v1.12/openshift/release/artifacts/eventing-kafka-controller.yaml -O ./knative-operator/hack/../../knative-operator/deploy/resources/knativekafka/controller/eventing-kafka-controller.yaml
WARNING: The certificate is NOT trusted. The certificate issuer is unknown.
Internal error: Unexpected relative path: './knative-operator/hack/..'
So this patch uses real paths.

  • run make generated-files

@openshift-ci openshift-ci bot requested review from creydr and matzew May 13, 2024 19:54
@skonto skonto requested review from ReToCode and removed request for matzew May 13, 2024 19:55
skonto
skonto commented May 13, 2024
View reviewed changes
olm-catalog/serverless-operator/project.yaml
@@ -31,14 +31,14 @@ requirements:
max: '4.15'
label: 'v4.12'
dependencies:
serving: knative-v1.12
serving: knative-v1.14
Copy link
Contributor Author

@skonto skonto May 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a mechanism to ignore this gap 1.12 -> 1.14? What is the status with version checking?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine (not tested). We removed the semver check in S-O.

ReToCode
ReToCode reviewed May 14, 2024
View reviewed changes
openshift-knative-operator/cmd/operator/kodata/ingress/1.14/kourier/1-net-kourier.yaml Outdated
@@ -97,15 +97,6 @@ data:
exact: GET
route:
cluster: service_stats
- match:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skonto what is the status of your kourier graceful shutdown testing?

Copy link
Contributor Author

@skonto skonto May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to do a PR against net-kourier openshift-knative/net-kourier#130 (comment) cherry-pick failed. We have this for 1.33 so we will get results from QA.

@ReToCode
Copy link
Member

LGTM.

@skonto skonto mentioned this pull request May 14, 2024
Merged
@skonto skonto changed the title [WIP] Bump Serving manifests to 1.14 Bump Serving manifests to 1.14 May 14, 2024
@skonto
Copy link
Contributor Author

skonto commented May 14, 2024

/hold we need the new net-kourier manifests

@skonto
Copy link
Contributor Author

skonto commented May 14, 2024

/unhold

ReToCode
ReToCode approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 14, 2024
@openshift-ci openshift-ci bot removed the lgtm label May 14, 2024
@ReToCode
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2781e56 into openshift-knative:main May 14, 2024
10 of 12 checks passed
@creydr creydr mentioned this pull request May 14, 2024
Merged
@skonto skonto mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@creydr creydr Awaiting requested review from creydr

Assignees

@ReToCode ReToCode

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skonto @ReToCode