-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Serving manifests to 1.14 #2656
Bump Serving manifests to 1.14 #2656
Conversation
@@ -31,14 +31,14 @@ requirements: | |||
max: '4.15' | |||
label: 'v4.12' | |||
dependencies: | |||
serving: knative-v1.12 | |||
serving: knative-v1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a mechanism to ignore this gap 1.12 -> 1.14? What is the status with version checking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine (not tested). We removed the semver check in S-O.
@@ -97,15 +97,6 @@ data: | |||
exact: GET | |||
route: | |||
cluster: service_stats | |||
- match: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skonto what is the status of your kourier graceful shutdown testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to do a PR against net-kourier openshift-knative/net-kourier#130 (comment) cherry-pick failed. We have this for 1.33 so we will get results from QA.
LGTM. |
/hold we need the new net-kourier manifests |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2781e56
into
openshift-knative:main
Fixes JIRA #
Proposed Changes
make generated-files